Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backstory:
Few days ago I setup a public 3rd party Minecraft server for me and my friends, but some port scanning griefer found it and wrecked havoc. After setting a whitelist and installing LoginSecurity, he can no longer get in, but I can see from the logs that he's trying his hardest - constantly trying commonly used names, changing IPs and so on.
While I'm fairly happy with LoginSecurity, it doesn't seem to have any anti-abuse mechanisms, so I'm a bit worried that the guy might finally bruteforce his way in. Therefore, I decided to bite the bullet and try to implement some mechanisms myself.
This PR adds basic banning functionality in 2 flavors:
Both are off by default and are toggable in the config in the new ban section.
As an addition, there's another switch there too (notify-ops) which when enabled, sends a message to each server OP if a ban was to occur.
Side note, I know nothing about Java so this was written as my best approximation of "how this change really should look like", comments welcome!
Corresponding Translations PR: lenis0012/Translations#209