Add Torch matrix test + improve sparse matrix hypothesis infra#408
Merged
mdekstrand merged 24 commits intolenskit:mainfrom Jun 1, 2024
Merged
Add Torch matrix test + improve sparse matrix hypothesis infra#408mdekstrand merged 24 commits intolenskit:mainfrom
mdekstrand merged 24 commits intolenskit:mainfrom
Conversation
Member
Author
|
This is testing PyTorch bug pytorch/pytorch#127491, which is exercised in isolation in https://github.com/mdekstrand/torch-spmv-bug-repro. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
==========================================
- Coverage 86.57% 86.27% -0.31%
==========================================
Files 48 48
Lines 3188 3212 +24
==========================================
+ Hits 2760 2771 +11
- Misses 428 441 +13 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the test utilities for generating sparse matrices for testing, and adds tests for PyTorch sparse matrix logic to ensure that our underlying compute substrate is well-behaved for algorithm implementation.