Skip to content

Add Torch matrix test + improve sparse matrix hypothesis infra#408

Merged
mdekstrand merged 24 commits intolenskit:mainfrom
mdekstrand:feature/test-matrix-logic
Jun 1, 2024
Merged

Add Torch matrix test + improve sparse matrix hypothesis infra#408
mdekstrand merged 24 commits intolenskit:mainfrom
mdekstrand:feature/test-matrix-logic

Conversation

@mdekstrand
Copy link
Member

This improves the test utilities for generating sparse matrices for testing, and adds tests for PyTorch sparse matrix logic to ensure that our underlying compute substrate is well-behaved for algorithm implementation.

@mdekstrand mdekstrand added the internals Internal infrastructure (parallelism, math, etc.) label May 29, 2024
@mdekstrand mdekstrand added this to the 2024.1 milestone May 29, 2024
@mdekstrand mdekstrand self-assigned this May 29, 2024
@mdekstrand
Copy link
Member Author

This is testing PyTorch bug pytorch/pytorch#127491, which is exercised in isolation in https://github.com/mdekstrand/torch-spmv-bug-repro.

@codecov
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.27%. Comparing base (81dfaff) to head (8ffed10).
Report is 791 commits behind head on main.

Files with missing lines Patch % Lines
lenskit/util/test.py 84.61% 4 Missing ⚠️
lenskit/data/matrix.py 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   86.57%   86.27%   -0.31%     
==========================================
  Files          48       48              
  Lines        3188     3212      +24     
==========================================
+ Hits         2760     2771      +11     
- Misses        428      441      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand marked this pull request as ready for review June 1, 2024 22:59
@mdekstrand mdekstrand merged commit 8ffed10 into lenskit:main Jun 1, 2024
@mdekstrand mdekstrand deleted the feature/test-matrix-logic branch June 1, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internals Internal infrastructure (parallelism, math, etc.)

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant