Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update load_movielens_df to return new standard field names #572

Merged
merged 6 commits into from
Dec 25, 2024

Conversation

mdekstrand
Copy link
Member

@mdekstrand mdekstrand commented Dec 24, 2024

This updates load_movielens_df to return the new column names instead of the legacy ones.

@mdekstrand mdekstrand added this to the 2025.1 milestone Dec 24, 2024
@mdekstrand mdekstrand added the data Data management support. label Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.20%. Comparing base (acd6f5d) to head (a3e3b3a).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
lenskit/lenskit/data/movielens.py 58.82% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #572   +/-   ##
=======================================
  Coverage   90.20%   90.20%           
=======================================
  Files         103      103           
  Lines        6388     6390    +2     
=======================================
+ Hits         5762     5764    +2     
  Misses        626      626           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit ce74335 into main Dec 25, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Data management support.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant