Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add predict_pipeline, remove data.bulk module, and clean up batch functions #582

Merged
merged 5 commits into from
Dec 31, 2024

Conversation

mdekstrand
Copy link
Member

This does some cleanups, removing the data.bulk module that is no longer needed now that we have item list collections, and adding a predict_pipeline function for use in tests, and adds a score batch function (and moves batch functions around).

@mdekstrand mdekstrand added the internals Internal infrastructure (parallelism, math, etc.) label Dec 31, 2024
@mdekstrand mdekstrand added this to the 2025.1 milestone Dec 31, 2024
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 91.42857% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.70%. Comparing base (4725505) to head (c0d4133).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
lenskit/lenskit/pipeline/common.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
- Coverage   90.71%   90.70%   -0.01%     
==========================================
  Files         108      105       -3     
  Lines        6540     6512      -28     
==========================================
- Hits         5933     5907      -26     
+ Misses        607      605       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 48eb645 into lenskit:main Dec 31, 2024
39 checks passed
@mdekstrand mdekstrand deleted the feature/cleanup-bulk branch December 31, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Internal infrastructure (parallelism, math, etc.)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant