Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate HPF to configuration object and fix BiasConfig serialization #600

Merged
merged 3 commits into from
Jan 11, 2025

Conversation

mdekstrand
Copy link
Member

This brings a couple small cleanups from #596:

  • migrate HPF to the configuration object design
  • fix BiasConfig serialization to sort the entity list for deterministic serialization

@mdekstrand mdekstrand added this to the 2025.1 milestone Jan 11, 2025
@mdekstrand mdekstrand added the internals Internal infrastructure (parallelism, math, etc.) label Jan 11, 2025
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.97%. Comparing base (204dcee) to head (09e05f7).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
+ Coverage   89.96%   89.97%   +0.01%     
==========================================
  Files         106      106              
  Lines        6567     6565       -2     
==========================================
- Hits         5908     5907       -1     
+ Misses        659      658       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 275b43b into lenskit:main Jan 11, 2025
39 checks passed
@mdekstrand mdekstrand deleted the feature/config-cleanups branch January 11, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Internal infrastructure (parallelism, math, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant