fix(ifort): address issue with Intel OneAPI ifort compilation #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified fastTwoDiff and fastTwoSum in order to compile with OneAPI ifort
(2021.5.0 20211109). Added an interface to m_geometry for fastTwoDiff and
fastTwoSum. Prior to modification got the following error
/Users/jdhughes/Documents/Development/coretran/src/spatial/sm_geometry.f90(230): error #6115: A separate interface body must have been declared in the program unit or an ancestor of the program unit for the separate module procedure. [FASTTWODIFF]
module subroutine fastTwoDiff(a, b, x, y)
--------------------^
/Users/jdhughes/Documents/Development/coretran/src/spatial/sm_geometry.f90(234): error #6451: A dummy argument name is required in this context. [A]
real(r64), intent(in) :: a
-----------------------------^
/Users/jdhughes/Documents/Development/coretran/src/spatial/sm_geometry.f90(236): error #6451: A dummy argument name is required in this context. [B]
real(r64), intent(in) :: b
-----------------------------^
/Users/jdhughes/Documents/Development/coretran/src/spatial/sm_geometry.f90(238): error #6451: A dummy argument name is required in this context. [X]
real(r64), intent(out) :: x
------------------------------^
/Users/jdhughes/Documents/Development/coretran/src/spatial/sm_geometry.f90(240): error #6451: A dummy argument name is required in this context. [Y]
real(r64), intent(out) :: y
------------------------------^
/Users/jdhughes/Documents/Development/coretran/src/spatial/sm_geometry.f90(249): error #6115: A separate interface body must have been declared in the program unit or an ancestor of the program unit for the separate module procedure. [FASTTWOSUM]
module subroutine fastTwoSum(a, b, x, y)
--------------------^
/Users/jdhughes/Documents/Development/coretran/src/spatial/sm_geometry.f90(253): error #6451: A dummy argument name is required in this context. [A]
real(r64), intent(in) :: a
-----------------------------^
/Users/jdhughes/Documents/Development/coretran/src/spatial/sm_geometry.f90(255): error #6451: A dummy argument name is required in this context. [B]
real(r64), intent(in) :: b
-----------------------------^
/Users/jdhughes/Documents/Development/coretran/src/spatial/sm_geometry.f90(257): error #6451: A dummy argument name is required in this context. [X]
real(r64), intent(out) :: x
------------------------------^
/Users/jdhughes/Documents/Development/coretran/src/spatial/sm_geometry.f90(259): error #6451: A dummy argument name is required in this context. [Y]
real(r64), intent(out) :: y
------------------------------^
compilation aborted for /Users/jdhughes/Documents/Development/coretran/src/spatial/sm_geometry.f90 (code 1)
make[2]: *** [CMakeFiles/coretran.dir/spatial/sm_geometry.f90.o] Error 1
make[1]: *** [CMakeFiles/coretran.dir/all] Error 2
make: *** [all] Error 2
closes leonfoks#28 reopen issue if sm_maths_d1D.f90 issue still exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified fastTwoDiff and fastTwoSum in order to compile with OneAPI ifort
(2021.5.0 20211109). Added an interface to m_geometry for fastTwoDiff and
fastTwoSum. Prior to modification got the following error
closes #28 reopen issue if sm_maths_d1D.f90 issue still exists