fix CheckBox animation throwing NullReferenceException on ObservableCollection changes

[Muniwedesu]

Use DependencyProperty for getting/setting the Tag property value to avoid it having the default value of 'null'

Pull request type

Please check the type of change your PR introduces:

• Update
• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes

What is the current behavior?

Issue Number: #1140

What is the new behavior?

• I didn't try to think about a proper solution/what's causing that issue and just used the code added in fix #1140 "System.ArgumentNullException: 'Value cannot be null. Parameter name: defaultDestinationValue'" #1398, it stopped throwing this exception in my use cases and animations seem to work properly.

Other information

[chucker]

Can you expand on what this fixes? You say #1140, but that one was closed (and thus presumably fixed) last year? Do you have a repro?

[Muniwedesu]

Can you expand on what this fixes? You say #1140, but that one was closed (and thus presumably fixed) last year? Do you have a repro?

That particular issue was with CardExpander and it was fixed, yes, this one does the same thing with CheckBox, maybe there are other controls like that.
And I should add that this only happens when resources are defined in the Window class (or anywhere else besides Application), I didn't notice that initially, sorry.

To reproduce just click on Remove/Clear button when checkbox is checked or was interacted with
wpfui-checkbox.zip

[Nuklon]

This is not complete, I don't have write access to the PR, but the Tag needs to be replaced as well:

                                        <controls:SymbolIcon.Clip>
                                            <MultiBinding Converter="{StaticResource ClipConverter}">
                                                <MultiBinding.Bindings>
                                                    <Binding Path="ActualWidth" RelativeSource="{RelativeSource Self}" />
                                                    <Binding Path="ActualHeight" RelativeSource="{RelativeSource Self}" />
                                                    <Binding Path="(animations:AnimationProperties.AnimationTagValue)" RelativeSource="{RelativeSource Self}" />
                                                </MultiBinding.Bindings>
                                            </MultiBinding>
                                        </controls:SymbolIcon.Clip>
                                        <animations:AnimationProperties.AnimationTagValue>
                                            <system:Double>1</system:Double>
                                        </animations:AnimationProperties.AnimationTagValue>