Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Hash-376): Hash should not be applied on inline.js #377

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

DennisJensen95
Copy link
Contributor

Changes:

  • Do not hash inline.js files as it will break the imports when using the webassembly in the frontend
  • When hashing files, if the file is within snippets is called inline and has an extension of .js then do not hash it

Changes:
- Do not hash inline.js files as it will break the imports when using the webassembly in the frontend
- When hashing files, if the file is within snippets is called inline and has an extension of .js then do not hash it
Copy link
Contributor

@benwis benwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I'm curious how you're getting these inline js files

@DennisJensen95
Copy link
Contributor Author

I got the inline.js by having my own local library for binding openlayer js and using wasm-bindgen 0.2.93. Then it produces it.

@DennisJensen95
Copy link
Contributor Author

I tried to describe it in #376 🙂

@DennisJensen95
Copy link
Contributor Author

@benwis how do i merge this, is that only maintainers? 😊

@benwis
Copy link
Contributor

benwis commented Oct 22, 2024

@benwis how do i merge this, is that only maintainers? 😊

Yeah, only maintainers can merge. I suppose I'm trying to figure out if this is something that's general and should go in as is or whether it's somewhat specific to you, in which case we'd want a way to configure it

@DennisJensen95
Copy link
Contributor Author

@benwis how do i merge this, is that only maintainers? 😊

Yeah, only maintainers can merge. I suppose I'm trying to figure out if this is something that's general and should go in as is or whether it's somewhat specific to you, in which case we'd want a way to configure it

Totally fair, let me know if I can do anything 😊

@benwis
Copy link
Contributor

benwis commented Oct 23, 2024

This seems pretty common for wasm-bindgen users, so I'm going to merge it in as is. Thanks for the PR!

@benwis benwis merged commit 25f184b into leptos-rs:main Oct 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants