CheckOnly should use a count of 0

letsencrypt · Feb 29, 2024 · 0926b5b · 0926b5b
1 parent 9e78787
commit 0926b5b
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/ratelimits/bucket.go b/ratelimits/bucket.go
@@ -265,7 +265,9 @@ func (builder *TransactionBuilder) FailedAuthorizationsPerDomainPerAccountCheckO
 		}
 
 		// Add a check-only transaction for each per domain per account bucket.
-		txn, err := newCheckOnlyTransaction(limit, perDomainPerAccountBucketKey, 1)
+		// The cost is 0, as we are only checking that the account and domain
+		// pair aren't already over the limit.
+		txn, err := newCheckOnlyTransaction(limit, perDomainPerAccountBucketKey, 0)
 		if err != nil {
 			return nil, err
 		}