features: remove deprecated features (#7805)

Fixes #7802
letsencrypt · Nov 13, 2024 · 5be3e99 · 5be3e99
1 parent 1d8cf3e
commit 5be3e99
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 31 deletions.
diff --git a/features/features.go b/features/features.go
@@ -15,23 +15,6 @@ import (
 // then call features.Set(parsedConfig) to load the parsed struct into this
 // package's global Config.
 type Config struct {
-	// Deprecated features. These features have no effect. Removing them from
-	// configuration is safe.
-	//
-	// Once all references to them have been removed from deployed configuration,
-	// they can be deleted from this struct, after which Boulder will fail to
-	// start if they are present in configuration.
-	CAAAfterValidation                bool
-	AllowNoCommonName                 bool
-	SHA256SubjectKeyIdentifier        bool
-	EnforceMultiVA                    bool
-	MultiVAFullResults                bool
-	CertCheckerRequiresCorrespondence bool
-	ECDSAForAll                       bool
-	CheckRenewalExemptionAtWFE        bool
-	TrackReplacementCertificatesARI   bool
-	UseKvLimitsForNewAccount          bool
-
 	// ServeRenewalInfo exposes the renewalInfo endpoint in the directory and for
 	// GET requests. WARNING: This feature is a draft and highly unstable.
 	ServeRenewalInfo bool

diff --git a/test/config-next/cert-checker.json b/test/config-next/cert-checker.json
@@ -18,7 +18,6 @@
 		],
 		"ctLogListFile": "test/ct-test-srv/log_list.json",
 		"features": {
-			"CertCheckerRequiresCorrespondence": true,
 			"CertCheckerChecksValidations": true,
 			"CertCheckerRequiresValidations": true
 		}

diff --git a/test/config/ra.json b/test/config/ra.json
@@ -104,10 +104,6 @@
 				}
 			}
 		},
-		"features": {
-			"CheckRenewalExemptionAtWFE": true,
-			"UseKvLimitsForNewAccount": true
-		},
 		"ctLogs": {
 			"stagger": "500ms",
 			"logListFile": "test/ct-test-srv/log_list.json",

diff --git a/test/config/sa.json b/test/config/sa.json
@@ -46,9 +46,6 @@
 					]
 				}
 			}
-		},
-		"features": {
-			"TrackReplacementCertificatesARI": true
 		}
 	},
 	"syslog": {

diff --git a/test/config/wfe2.json b/test/config/wfe2.json
@@ -103,10 +103,7 @@
 		"authorizationLifetimeDays": 30,
 		"pendingAuthorizationLifetimeDays": 7,
 		"features": {
-			"ServeRenewalInfo": true,
-			"TrackReplacementCertificatesARI": true,
-			"CheckRenewalExemptionAtWFE": true,
-			"UseKvLimitsForNewAccount": true
+			"ServeRenewalInfo": true
 		}
 	},
 	"syslog": {

diff --git a/test/integration/issuance_test.go b/test/integration/issuance_test.go
@@ -75,8 +75,7 @@ func TestFirstCSRSANHoistedToCN(t *testing.T) {
 }
 
 // TestCommonNameSANsTooLong tests that, when the names in an order and CSR are
-// too long to be hoisted into the CN, the correct behavior results (depending
-// on the state of the AllowNoCommonName feature flag).
+// too long to be hoisted into the CN, the correct behavior results.
 func TestCommonNameSANsTooLong(t *testing.T) {
 	t.Parallel()