Address even more comments forever

letsencrypt · May 29, 2024 · db8d228 · db8d228
1 parent bad5f5a
commit db8d228
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/ca/ca.go b/ca/ca.go
@@ -684,10 +684,6 @@ func tbsCertIsDeterministic(lintCertBytes []byte, leafCertBytes []byte) error {
 		return fmt.Errorf("while extracting leaf TBS cert: %w", err)
 	}
 
-	if lintRawTBSCert == nil || leafRawTBSCert == nil {
-		return fmt.Errorf("while extracting TBS cert: %w", err)
-	}
-
 	if !bytes.Equal(lintRawTBSCert, leafRawTBSCert) {
 		return fmt.Errorf("mismatch between lintCert and leafCert RawTBSCertificate DER bytes: \"%x\" != \"%x\"", lintRawTBSCert, leafRawTBSCert)
 	}

diff --git a/ca/ca_test.go b/ca/ca_test.go
@@ -1392,8 +1392,8 @@ func TestVerifyTBSCertIsDeterministic(t *testing.T) {
 			t.Parallel()
 			err := tbsCertIsDeterministic(testCase.lintCertBytes, testCase.leafCertBytes)
 			if testCase.errorSubstr != "" {
-				test.AssertContains(t, fmt.Sprint(err), testCase.errorSubstr)
 				test.AssertError(t, err, "your lack of errors is disturbing")
+				test.AssertContains(t, err.Error(), testCase.errorSubstr)
 			} else {
 				test.AssertNotError(t, err, "unexpected error")
 			}