Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boulder-va should explicitly record the quorum met for the issuance (eg, 5/6 or 6/6) #7616

Open
5 tasks
Tracked by #7612
mcpherrinm opened this issue Jul 19, 2024 · 0 comments
Open
5 tasks
Tracked by #7612
Assignees
Milestone

Comments

@mcpherrinm
Copy link
Contributor

mcpherrinm commented Jul 19, 2024

Per MPIC ballot, we should record this explicitly in audit logs.

We need to make sure that we can distinguish between a positive failure from an RVA versus not waiting longer for a response.


Notes added by @beautifulentropy

RVA audit logs are not collected to tape, we'll need to:

  • Make remote perspective quorum configurable
  • Return Perspective and RIR from RVA -> VA
  • Log remote perspective quorum result
  • Record gRPC timeouts and cancellations distinctly from validation failures
  • During deployments and scaling actions, ensure all attempts dispatched by the VA -> RVA are completed and logged. Any timeouts in the graceful shutdown process should be longer than the VA -> RVA gRPC timeout.
beautifulentropy added a commit that referenced this issue Oct 10, 2024
- Add `Perspective` and `RIR` fields to the remote-va configuration
- Configure RVA ValidationAuthorityImpl instances with the contents of
the JSON configuration
- Configure VA ValidationAuthorityImpl instances with the constant
`va.PrimaryPerspective`
- Log `Perspective` for non-Primary Perspectives, per the MPIC
requirements in section 5.4.1 (2) vii of the BRs. Also log the RIR for
posterity.
- Introduce `ValidationResult` RPC fields `Perspective` and `Rir`, which
are not currently used but will be required for corroboration in #7616

Fixes #7613
Part of #7615
Part of #7616
@beautifulentropy beautifulentropy self-assigned this Oct 15, 2024
@beautifulentropy beautifulentropy added this to the Sprint 2024-10-15 milestone Oct 15, 2024
@jsha jsha modified the milestones: Sprint 2024-11-05, 2024-11-12 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants