Remove code that rejects old TLS requests #7711
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's worth noting that while we've configured our NGINX LBs to reject connections using older TLS versions, other folks using Boulder may not have. |
aarongable
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
The Boulder WFE accepts incoming connections (from our load balancers) via either TLS or plain HTTP. When those connections are made over TLS, it already enforces that the client be using TLS 1.3 or above. The code being removed here is for the other codepath, where the load balancer connects to the Boulder WFE over plain HTTP and includes the original TLS version as a header.
I think it's fine to remove this check.
beautifulentropy
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7710