Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code that rejects old TLS requests #7711

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Remove code that rejects old TLS requests #7711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions wfe2/wfe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,11 +285,6 @@ func (wfe *WebFrontEndImpl) HandleFunc(mux *http.ServeMux, pattern string, h web
if request.URL != nil {
logEvent.Slug = request.URL.Path
}
tls := request.Header.Get("TLS-Version")
if tls == "TLSv1" || tls == "TLSv1.1" {
wfe.sendError(response, logEvent, probs.Malformed("upgrade your ACME client to support TLSv1.2 or better"), nil)
return
}
if request.Method != "GET" || pattern == newNoncePath {
nonceMsg, err := wfe.gnc.Nonce(ctx, &emptypb.Empty{})
if err != nil {
Expand Down
15 changes: 0 additions & 15 deletions wfe2/wfe_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3787,21 +3787,6 @@ func TestIncidentARI(t *testing.T) {
test.AssertEquals(t, ri.SuggestedWindow.End.Before(wfe.clk.Now()), true)
}

func TestOldTLSInbound(t *testing.T) {
wfe, _, _ := setupWFE(t)
req := &http.Request{
URL: &url.URL{Path: "/directory"},
Method: "GET",
Header: http.Header(map[string][]string{
http.CanonicalHeaderKey("TLS-Version"): {"TLSv1"},
}),
}

responseWriter := httptest.NewRecorder()
wfe.Handler(metrics.NoopRegisterer).ServeHTTP(responseWriter, req)
test.AssertEquals(t, responseWriter.Code, http.StatusBadRequest)
}

func Test_sendError(t *testing.T) {
features.Reset()
wfe, _, _ := setupWFE(t)
Expand Down