Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add govulncheck to CI #6963
Add govulncheck to CI #6963
Changes from 24 commits
86f46ed
5f36536
6ae89b2
50d07a1
fa25ae3
c90d70c
a2ece93
0c56436
d46118a
ba7a1fe
0557cc5
6d76aef
631ea05
2b2261a
a41e6f3
343f1d0
271c8bd
4ef7bb3
64c8d9a
8385235
40dfcf9
379b435
0ca8a92
6ca0506
fc952ac
f7d2ddd
5ebd869
4fdd71a
d09895e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why combine the rsyslog editing steps with the install-go step? Though I do like combining the different sed invocations into a single invocation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN
,COPY
, andADD
create new layers which use some amount of disk space. Having less layers is more efficient disk space-wise. There's further optimizations that can be done with a multi-stage build, but that's outside the scope of this PR. Hell, even this change is now outside the scope of this PR because I changed strategies mid-way through.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layers prior to this change
Layers after this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, and that's why for instance we put a bunch of stuff inside
build.sh
rather than in RUN commands directly. Perhaps thesed
commands should go insidebuild.sh
? That makes more sense to me logically than clustering them withinstall-go.sh
. It would probably be interesting to look at the git history and see if there's a specific reason they're in the Dockerfile rather than build.sh.