ceremony: Distinguish between intermediate and cross-sign ceremonies #7005

pgporada · 2023-07-19T20:39:48Z

In //cmd/ceremony:

Added CertificateToCrossSignPath to the cross-certificate ceremony type. This new input field takes an existing certificate that will be cross-signed and performs checks against the manually configured data in each ceremony file.
Added byte-for-byte subject/issuer comparison checks to root, intermediate, and cross-certificate ceremonies to detect that signing is happening as expected.
Added Fermat factorization check from the //goodkey package to all functions that generate new key material.

In //linter:

The Check function now exports linting certificate bytes. The idea is that a linting certificate's tbsCertificate bytes can be compared against the final certificate's tbsCertificate bytes as a verification that x509.CreateCertificate was deterministic and produced identical DER bytes after each signing operation.

Other notable changes:

Re-orders the issuers list in each CA config to match staging and production. There is an ordering issue mentioned by @aarongable two years ago on IN-5913 that didn't make it's way back to this repository.

Order here matters – the default chain we serve for each intermediate should be the first listed chain containing that intermediate.
Enables ECDSAForAll in config-next CA configs to match Staging.
Generates 2x new ECDSA subordinate CAs cross-signed by an RSA root and adds these chains to the WFE for clients to download.
Increased the test.sh startup timeout to account for the extra ceremony run time.

Fixes #7003

…emonies

pgporada · 2023-07-20T14:50:20Z

If any of OCSPURL, CRLURL, or IssuingCertificateURL are present in the parent certificate, should we either use that over the values provided in the config file, perform an equality check, or just leave this section alone and only configure it via the config file?

…ework

…elds. Remove input for crossCert validation method

…nformative failure message

cmd/ceremony/main.go

cmd/ceremony/cert.go

cmd/ceremony/main.go

Co-authored-by: Aaron Gable <aaron@letsencrypt.org>

Removes the SignatureAlgorithm field while constructing the lint issuer. Depending on the realIssuer, which could be either an intermediate or cross-signed intermediate, the SignatureAlgorithm of that certificate may differ from the root certificate that had signed it causing the following error during CA startup. ``` Starting service boulder-ca-a 16:49:29.437776 3 boulder-ca qM-tDQA [AUDIT] Couldn't load issuers: failed to create lint issuer: x509: requested SignatureAlgorithm does not match private key type ``` Related to work done in #7005. --------- Co-authored-by: Aaron Gable <aaron@letsencrypt.org>

In #7005 several safety checks were added to the `ceremony` tool: This change extracts the `RawSubject` to `RawIssuer` DER byte comparison into the `//linter` package proper so that it can serve both `//ca` and `//cmd/ceremony`. Adds a helper function `verifyTBSCertificateDeterminism` to `//ca` similar to an existing check in `//cmd/ceremony`. This code is not shared because we want `//cmd/ceremony` to largely stand alone from boulder proper. The helper performs a byte comparison on the `RawTBSCertificate` DER bytes for a given linting certificate and leaf certificate. The goal is to verify that `x509.CreateCertificate` was deterministic and produced identical DER bytes after each signing operation. Fixes #6965

ceremony: Handle distinctions between intermediate and cross-sign cer…

076abd3

…emonies

pgporada changed the title ~~ceremony: Handle distinctions between intermediate and cross-sign ceremonies~~ ceremony: Distinguish between intermediate and cross-sign ceremonies Jul 20, 2023

pgporada force-pushed the ceremony-cross-cert-rework branch 2 times, most recently from 6e6037e to 076abd3 Compare July 20, 2023 15:02

pgporada added 25 commits July 20, 2023 12:14

Merge remote-tracking branch 'origin/main' into ceremony-cross-cert-r…

8b5b434

…ework

Make a specific cross-cert profile and ceremony function

4163d40

Add cross-cert config validation unit test

a7a1cfb

Split linting certificate into separate function

59c470b

Don't throwaway linting certificate bytes from //linter package

21d737d

Extra validations on RawIssuer and RawSubject fields

a91c75f

More verifications

881389a

Perform checks on root and intermediate ceremony too

3fe4e96

Wire up GoodKey checking

21ed896

Fix self-signed root linting and move utility functions into cert.go

11638af

Fix context lint warning by using an empty non-nil context

46fe904

intermediate and crossCert ceremony profiles should check the same fi…

9c57814

…elds. Remove input for crossCert validation method

Add cross-certificate ceremonies integration tests

09aa2f2

Use correct InputCertPath for cross sign ceremonies and output more i…

b50b22d

…nformative failure message

Skip lints not relevant to cross-signed subordinate CAs

ab89802

Remove arg from crossCert.validate

6786449

Add cross-signed intermediates to CA configs

177461b

Use term subordinate CA instead of intermediate

454a4c0

Add test cases for cross signed certs and update expected error messages

618bc0e

Increase startup timeout and add additional log line about it

63a4cb7

Add function to load public key and do more testing

2a71a8d

Fix cross-certificate generation for integration tests

8a11f16

Add cross-signed intermediates to the issuerCerts list

6697bd5

Fix lints

95cc539

Only need to serve the issuer chains from the WFE

4f404b7

pgporada requested a review from aarongable August 7, 2023 18:08

Been awake too many hours and removed too much code

e99b427

aarongable reviewed Aug 10, 2023

View reviewed changes

beautifulentropy self-requested a review August 10, 2023 17:38

pgporada added 6 commits August 11, 2023 14:07

Address stylistic comments

64f8b94

Still working on more BR and CPS verifications

ca1f430

Still addressing comments

567e1f2

Fix ineffectual assignment

9978b82

Allow genCert to display command output

c20dcc5

Copy EKUs from to-be-cross-signed cert over to the lint cert

fc6fc4c

pgporada requested a review from aarongable August 16, 2023 18:52

Test that EKUs match between lintcert and to-be-cross-signed

9d38688

aarongable previously approved these changes Aug 16, 2023

View reviewed changes

Update cmd/ceremony/cert.go

4e7a822

Co-authored-by: Aaron Gable <aaron@letsencrypt.org>

pgporada dismissed aarongable’s stale review via 4e7a822 August 17, 2023 15:28

pgporada added 5 commits August 17, 2023 12:41

Address comments

979ee46

Prevent issuance if linting hasn't been done

72b7d76

Fix error message

950333e

I should learn how to use structs and types

308a6d0

I'm of the type that fails at types

676f793

pgporada requested a review from aarongable August 17, 2023 18:20

pgporada mentioned this pull request Aug 17, 2023

Add historic ceremonies and restructure project letsencrypt/ceremony-demos#10

Merged

aarongable approved these changes Aug 22, 2023

View reviewed changes

beautifulentropy approved these changes Aug 23, 2023

View reviewed changes

pgporada merged commit 72e01b3 into main Aug 23, 2023
22 checks passed

pgporada deleted the ceremony-cross-cert-rework branch August 23, 2023 18:01

pgporada mentioned this pull request Aug 24, 2023

linter: Remove SignatureAlgorithm field from makeIssuer #7049

Merged

pgporada mentioned this pull request May 22, 2024

ca/linter: Port safety checks from ceremony tool #7498

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ceremony: Distinguish between intermediate and cross-sign ceremonies #7005

ceremony: Distinguish between intermediate and cross-sign ceremonies #7005

pgporada commented Jul 19, 2023 •

edited

Loading

pgporada commented Jul 20, 2023 •

edited

Loading

ceremony: Distinguish between intermediate and cross-sign ceremonies #7005

ceremony: Distinguish between intermediate and cross-sign ceremonies #7005

Conversation

pgporada commented Jul 19, 2023 • edited Loading

pgporada commented Jul 20, 2023 • edited Loading

pgporada commented Jul 19, 2023 •

edited

Loading

pgporada commented Jul 20, 2023 •

edited

Loading