gRPC: reject request if clock skew is too large #7686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
force-pushed
the
gossip-time
branch
from
495cf8d
to
696dc56
Compare
aarongable
force-pushed
the
gossip-time
branch
from
696dc56
to
bbdde33
Compare
jsha
requested changes
Aug 28, 2024
aarongable
force-pushed
the
gossip-time
branch
from
8740b40
to
a96158b
Compare
jsha
previously approved these changes
Aug 28, 2024
aarongable
force-pushed
the
gossip-time
branch
from
a96158b
to
23c262e
Compare
jsha
approved these changes
Aug 28, 2024
beautifulentropy
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have our gRPC server interceptor check for excessive clock skew between its own clock and gRPC client clocks. Do this by taking advantage of the client request timestamp that most clients already supply for the purpose of measuring cross-service latency. If the included timestamp is more than 10 minutes from the gRPC server's local time, immediately error out.
To keep the integration tests -- which heavily rely on clock manipulation -- working, use build tags to disable this behavior during integration testing.
Fixes #7684