ratelimits: Set a TTL each time we store bucket data in Redis #7720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
previously approved these changes
Sep 23, 2024
aarongable
requested review from
a team and
jsha
and removed request for
a team
Co-authored-by: Aaron Gable <aaron@letsencrypt.org>
aarongable
approved these changes
Sep 24, 2024
|
Is this correct? Isn't theoretical arrival time for the arrival of a single token? I think expiring the record at the TAT means the rate limit will get reset each time a single token arrives, effectively granting a whole bucket's worth of tokens instantly. |
|
The TAT is the time at which the bucket will be full again, and if the bucket is full then it's okay for us to lose the K/V representing it. |
|
Oh, right, and that's described in the docs. My confusion was: I thought TAT was the arrival time of a token, but in GCRA it's described as the arrival time of a packet (or in our case, a request). |
jsha
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the Redis TTL to TAT (theoretical arrival time) plus a 10-minute buffer to account for possible clock skew.