Introduce separate UpdateRegistrationContact & UpdateRegistrationKey methods in RA & SA #7735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
reviewed
Oct 4, 2024
aarongable
reviewed
Oct 31, 2024
| if core.IsAnyNilOrZero(req.RegistrationID, req.Jwk) { | ||
| return nil, errIncompleteGRPCRequest | ||
| } | ||
|
|
There was a problem hiding this comment.
Note for the future: I'd like the RA to perform any checks (is it weak? is it in the blocked-keys list? etc) on the newly-supplied key, rather than leaving that to the WFE. But that doesn't need to happen in this PR.
aarongable
approved these changes
Nov 6, 2024
beautifulentropy
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce separate UpdateRegistrationContact & UpdateRegistrationKey methods in RA & SA
Clear contact field during DeactivateRegistration
Part of #7716
Part of #5554