WFE/nonce: Add NonceHMACKey field #7793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jprenken, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
beautifulentropy
previously approved these changes
Nov 8, 2024
aarongable
reviewed
Nov 8, 2024
jsha
reviewed
Nov 9, 2024
beautifulentropy
previously approved these changes
Nov 11, 2024
jsha
requested changes
Nov 12, 2024
This case was added to work around a test case that didn't fill it out; instead, fill DNSNames for that test case.
jsha
approved these changes
Nov 12, 2024
beautifulentropy
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new WFE & nonce config field,
NonceHMACKey, which uses the newcmd.HMACKeyConfigtype. Deprecate theNoncePrefixKeyconfig field.Generalize the error message when validating
HMACKeyConfiginconfig.Remove the deprecated
UseDerivablePrefixconfig field, which is no longer used anywhere.Part of #7632