ra: fix unittest for resetting pause limit #7813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestPerformValidation_FailedThenSuccessfulValidationResetsPauseIdentifiersRatelimit checks for a bucket being empty after a reset. However, that bucket is based on an account ID that is shared across multiple test cases. Instead, use a unique account and domain for this test.
jsha
force-pushed
the
fix-TestPerformValidation_FailedThenSuccessfulValidationResetsPauseIdentifiersRatelimit
branch
from
06f05f5
to
8134588
Compare
jprenken
approved these changes
Nov 14, 2024
jprenken
requested review from
a team and
beautifulentropy
and removed request for
a team
jsha
deleted the
fix-TestPerformValidation_FailedThenSuccessfulValidationResetsPauseIdentifiersRatelimit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestPerformValidation_FailedThenSuccessfulValidationResetsPauseIdentifiersRatelimit checks for a bucket being empty after a reset. However, that bucket is based on an account ID that is shared across multiple test cases. Instead, use a unique account and domain for this test.
Fixes #7812