Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RA: Make calls to countCertificateIssued and countFailedValidations synchronous #7824

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

beautifulentropy
Copy link
Member

@beautifulentropy beautifulentropy commented Nov 15, 2024

Solves CI flakes in TestCertificatesPerDomain and TestIdentifiersPausedForAccount that are the result of a race on the Redis database. This has the downside of making failed validations and successful finalizations take slightly longer.

@beautifulentropy beautifulentropy marked this pull request as ready for review November 15, 2024 21:05
@beautifulentropy beautifulentropy requested a review from a team as a code owner November 15, 2024 21:05
Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good tradeoff to me.

@jsha
Copy link
Contributor

jsha commented Nov 15, 2024

Huh, I haven't seen this failure before:

--- FAIL: TestAdminClearEmail (0.04s)
    admin_test.go:43: clearing email via admin tool (./bin/admin -config test/config/admin.json -dry-run=false update-email -address example@mail.example.letsencrypt.org -clear): 21:11:00.138242 6 admin 8MWbnQQ Debug server listening on :8014
        21:11:00.138274 6 admin p6yD7gM Versions: admin=(Unspecified Unspecified) Golang=(go1.23.1) BuildHost=(Unspecified)
        21:11:00.138496 3 admin 9siVpw4 [AUDIT] unable to boot debug server on :8014: listen tcp :8014: bind: address already in use
        : exit status 1
FAIL
FAIL	github.com/letsencrypt/boulder/test/integration	37.912s
FAIL

Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, makes sense.

@beautifulentropy beautifulentropy merged commit 3506f09 into main Nov 15, 2024
12 checks passed
@beautifulentropy beautifulentropy deleted the frost-those-flakes branch November 15, 2024 21:33
@beautifulentropy
Copy link
Member Author

Huh, I haven't seen this failure before:

--- FAIL: TestAdminClearEmail (0.04s)
    admin_test.go:43: clearing email via admin tool (./bin/admin -config test/config/admin.json -dry-run=false update-email -address example@mail.example.letsencrypt.org -clear): 21:11:00.138242 6 admin 8MWbnQQ Debug server listening on :8014
        21:11:00.138274 6 admin p6yD7gM Versions: admin=(Unspecified Unspecified) Golang=(go1.23.1) BuildHost=(Unspecified)
        21:11:00.138496 3 admin 9siVpw4 [AUDIT] unable to boot debug server on :8014: listen tcp :8014: bind: address already in use
        : exit status 1
FAIL
FAIL	github.com/letsencrypt/boulder/test/integration	37.912s
FAIL

Yeah, me either. We should keep a lookout for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants