Add passthrough handler #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsha
force-pushed
the
passthrough-handler
branch
from
118fb9b
to
73639d6
Compare
This passes through GET requests other than get-entries to the CT backend. This is particularly useful for some log scanning tools that call `/ct/v1/get-sth` before beginning their scan. This is mainly intended as a convenience for small scale testing. In production we plan to bypass this tool for all request paths other than /ct/v1/get-entries.
jsha
force-pushed
the
passthrough-handler
branch
from
73639d6
to
41e4ee0
Compare
jsha
requested review from
a team and
aarongable
and removed request for
a team
aarongable
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
LGTM. Once this lands, #17 will need to be updated to pass the mux instead of the handler on line 464.
beautifulentropy
requested changes
Sep 7, 2023
main.go
Outdated
| return | ||
| } | ||
| url := fmt.Sprintf("%s%s", p.logURL, r.URL.Path) | ||
| r, err := http.NewRequestWithContext(r.Context(), http.MethodGet, url, nil) |
There was a problem hiding this comment.
You are reusing the input r *http.Request here.
Suggested change
| r, err := http.NewRequestWithContext(r.Context(), http.MethodGet, url, nil) | |
| req, err := http.NewRequestWithContext(r.Context(), http.MethodGet, url, nil) |
| w.WriteHeader(http.StatusInternalServerError) | ||
| fmt.Fprintf(w, "fetching %s: %s\n", url, err) | ||
| return | ||
| } |
There was a problem hiding this comment.
I think resp.Body needs to be closed before we return.
Suggested change
| } | |
| } | |
| defer resp.Body.Close() |
main.go
Outdated
| } | ||
|
|
||
| w.WriteHeader(resp.StatusCode) | ||
| io.Copy(w, resp.Body) |
There was a problem hiding this comment.
io.Copy could return an error and it would be going unchecked.
beautifulentropy
approved these changes
Sep 7, 2023
aarongable
approved these changes
Sep 7, 2023
jsha
added a commit
that referenced
this pull request
Sep 12, 2023
This changed in #16 to accept only the exact request path `/ct/v1/get-entries`. But it turns out it's easier for the reverse-proxy configuration if we go back to the old behavior: accepting any request path ending in `/ct/v1/get-entries`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes through GET requests other than get-entries to the CT backend. This is particularly useful for some log scanning tools that call
/ct/v1/get-sthbefore beginning their scan.This is mainly intended as a convenience for small scale testing. In production we plan to bypass this tool for all request paths other than /ct/v1/get-entries.