Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latency metrics #25

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Add latency metrics #25

merged 2 commits into from
Sep 14, 2023

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Sep 13, 2023

These record both overall response latency and per-backend latency.

@jsha jsha requested review from a team and aarongable and removed request for a team September 13, 2023 19:11
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
Copy link

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo Phil's suggestions for better metric helptext/descriptions.

Base automatically changed from actually-set-full-request-timeout to main September 13, 2023 20:18
These record both overall response latency and per-backend latency.
@pgporada pgporada merged commit d754d0d into main Sep 14, 2023
2 checks passed
@pgporada pgporada deleted the more-metrics branch September 14, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants