fix: handle parallel tool call streaming with index-based ID tracking#59
Merged
fix: handle parallel tool call streaming with index-based ID tracking#59
Conversation
The Letta API follows OpenAI's streaming format for parallel tool calls:
only the first chunk per tool call includes `tool_call_id`. Subsequent
chunks identify themselves via `index` only. The prior accumulation logic
keyed solely on `tool_call_id`, causing every argument-carrying chunk to
fall through unbuffered -- producing N individual tool_call messages with
empty args instead of one complete message per tool call.
Changes:
- Track index->tool_call_id mapping so subsequent chunks resolve via index
- Handle both flat and OpenAI nested `function: { name, arguments }` format
- Clear stale streamQueue on each send() to prevent cross-turn desync
- Skip stream_event when deciding whether to flush pending tool calls
Written by Cameron and Letta Code
"The only way to do great work is to love what you do." -- Steve Jobs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_call_id, subsequent chunks useindexonlytool_call_id, so argument chunks (which lack the ID) fell through unbufferedtool_callSDK messages with emptytoolInput: {}instead of one complete message per callChanges
indexToToolCallIdmap associatesindexwithtool_call_idfrom the first chunk, so subsequent chunks resolve correctly{ name, arguments, tool_call_id }and nested{ function: { name, arguments } }formatsstreamQueueon eachsend()to prevent cross-turn message leaksstream_eventarrives (prevents premature flush of incomplete accumulation)Test plan
toolInput: {}for 4 tool callstoolInputtool-call-args-accumulation.test.tssuiteWritten by Cameron and Letta Code
"The only way to do great work is to love what you do." -- Steve Jobs