Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix block render original render callback 3rd arg in 0.4 lts version #261

Closed
wants to merge 2 commits into from
Closed

Fix block render original render callback 3rd arg in 0.4 lts version #261

wants to merge 2 commits into from

Conversation

menno-ll
Copy link
Member

@menno-ll menno-ll commented Nov 9, 2023 •
edited
Loading

Issue link

#260

Description

Applies the same fix of #260 in the 0.4 lts version.
And then also the updated fix from Christiaan in #262.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@menno-ll menno-ll added the bug label Nov 9, 2023
@menno-ll menno-ll changed the title Fix original render callback 3rd arg in 0.4 lts version Fix block render original render callback 3rd arg in 0.4 lts version Nov 9, 2023
@menno-ll menno-ll mentioned this pull request Nov 9, 2023
Merged
6 tasks
@Mike-Hermans Mike-Hermans mentioned this pull request Jan 17, 2024
Merged
6 tasks
@Mike-Hermans
Copy link
Member

Closed in favour of #267 which includes a fix for WP 6.4+ as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NielsdeBlaauw NielsdeBlaauw NielsdeBlaauw approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@menno-ll @Mike-Hermans @NielsdeBlaauw