Fix unicode session behavior #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return self.session_class(data, sid=sid) | ||
| except: | ||
| return self.session_class(sid=sid) | ||
| raise |
There was a problem hiding this comment.
Development Artifact. In earlier iterations I raised a custom keg error code, good catch.
nZac
force-pushed
the
gh-fix-unicode-sessions
branch
from
ddddff2 to
c0162a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the data field to a large binary and assumes Unicode values instead of string data.
@3noch can you review this since we don't have CI for this.