Skip to content

Commit

Permalink
eve: installer: Add rootwait by default
Browse files Browse the repository at this point in the history
We have experiencing issues with installer due to USB Sticks that take a
few seconds to get detected by the system, leading to "rootfs not found"
errors. This commit adds "rootwait" parameter by default, so the kernel
will wait until root file system is available. The only drawback is that
kernel can wait indefinitely in case of a real failure, but this should be
easily noticed during the installer process. The old behavior can also
be easily configured by overriding dom0_extra_args.

By using rootwait, doesn't make sense to keep the optional entry with
rootdelay option, so it's removed.

Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
(cherry picked from commit 2668da4)
  • Loading branch information
rene committed Feb 21, 2025
1 parent 0dea84f commit 0c40c7f
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions pkg/eve/installer/grub_installer.cfg
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
function installer_submenus {
menuentry 'force rootdelay for slow USB controllers' {
set_global dom0_extra_args "$dom0_extra_args rootdelay=30"
}

menuentry 'do NOT install - collect black box instead' {
set_global dom0_cmdline "$dom0_cmdline eve_blackbox"
}
Expand Down Expand Up @@ -53,7 +49,7 @@ install_part="$cmddevice"
cat -s boot_uid "($install_part)/boot/.uuid"
set_global rootfs_title_suffix "-installer"
set_global do_extra_submenus "installer_submenus"
set_global dom0_extra_args "getty"
set_global dom0_extra_args "getty rootwait"
set_global eve_flavor kvm

# to handle the case where the rootfs is on a CD/ISO with a label
Expand Down

0 comments on commit 0c40c7f

Please sign in to comment.