newer version of linuxkit/init with more debugging options #4175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avi Deitcher <avi@deitcher.net>
rene
approved these changes
Aug 28, 2024
|
CI is not green with the same Storage failure, as I see for a lot of other PRs. So, consider it fine. |
OhmSpectator
approved these changes
Aug 28, 2024
|
Thanks @OhmSpectator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR #4161 bumped
linuxkit/initto a version that has extra cmdline debugging support vialinuxkit.runc_debug=1. This is a slight improvement, in that it controls debugging viarunc_debug=1, while enabling console output to be controlled separately vialinuxkit.runc_console=1.More importantly, the previous version, when in debug mode, tried to write to both console and file simultaneously, which made runc quite unhappy and made things hang. This fixes that.
I expect no functional changes here. If CI is green, it should be good to go.