Edge-Node Clustering miscellaneous bug fixes #4549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
naiming-zededa
commented
Jan 25, 2025
naiming-zededa
commented
- handle the ENC App Status and cluster reachable conditions and with error message status
- fix an issue in checkAppsStatus() of using staled oldStatus{}
- in multiple applications case, the there is a bug since now we changed the logic to not always publish the ENClusterAppStatus, need to use the correct oldStatus for the application
- fix the token rotation failure and waitfor cluster status bug and fix a bug in waiting for bootstrap server status, we can fall into the 'else' condition and get a wrong cert
- if not all-pods-ready, not printing the misleading 'applying node labels' message, instead log the 'Not all pods are ready'
- handle the case convert to single-node and immediately back to cluster-mode again. we need towait for the bootstrap 'cluster' status before moving on
- try to fix an issue of 'k3s.log' file rotation not taking effect once a while. the file size can not be truncated. Add a HUP signal before truncate the file
naiming-zededa
requested review from
OhmSpectator,
milan-zededa,
rouming,
zedi-pramodh and
eriknordmark
as code owners
naiming-zededa
force-pushed
the
naiming-misc-cluster-bugfixes
branch
2 times, most recently
from
f724b48 to
3107eb9
Compare
naiming-zededa
force-pushed
the
naiming-misc-cluster-bugfixes
branch
from
3107eb9 to
d89e34f
Compare
rene
reviewed
Jan 28, 2025
rene
reviewed
Jan 28, 2025
naiming-zededa
force-pushed
the
naiming-misc-cluster-bugfixes
branch
from
d89e34f to
d9ade52
Compare
naiming-zededa
force-pushed
the
naiming-misc-cluster-bugfixes
branch
from
d9ade52 to
b5364d1
Compare
naiming-zededa
force-pushed
the
naiming-misc-cluster-bugfixes
branch
from
b5364d1 to
e91485f
Compare
|
no conflict, but rebased again. |
- handle the ENC App Status and cluster reachable conditions and with
error message status
- fix an issue in checkAppsStatus() of using staled oldStatus{}
- in multiple applications case, the there is a bug since now we changed
the logic to not always publish the ENClusterAppStatus, need to use
the correct oldStatus for the application
- fix the token rotation failure and waitfor cluster status bug
and fix a bug in waiting for bootstrap server status, we can fall into
the 'else' condition and get a wrong cert
- if not all-pods-ready, not printing the misleading 'applying node
labels' message, instead log the 'Not all pods are ready'
- handle the case convert to single-node and immediately back to
cluster-mode again. we need towait for the bootstrap 'cluster' status
before moving on
- try to fix an issue of 'k3s.log' file rotation not taking effect once
a while. the file size can not be truncated. Add a HUP signal before
truncate the file
Signed-off-by: Naiming Shen <naiming@zededa.com>
naiming-zededa
force-pushed
the
naiming-misc-cluster-bugfixes
branch
from
e91485f to
5cd695f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.