Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monitor logs to collect-info bundle #4554

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Add monitor logs to collect-info bundle #4554

merged 1 commit into from
Jan 29, 2025

Conversation

rucoder
Copy link
Contributor

@rucoder rucoder commented Jan 28, 2025

  • save log for monitor TUI app in collect info bundle

@rucoder rucoder requested a review from rouming as a code owner January 28, 2025 02:08
@rucoder rucoder requested review from OhmSpectator and removed request for rouming January 28, 2025 02:08
@rucoder rucoder force-pushed the rucoder/monitor-collect-info branch 2 times, most recently from b84451e to 5f52ec8 Compare January 28, 2025 11:35
eriknordmark
eriknordmark approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eriknordmark
eriknordmark previously requested changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to rebase on master to get the arm builds to work.

@rucoder rucoder force-pushed the rucoder/monitor-collect-info branch from 5f52ec8 to 6333699 Compare January 29, 2025 08:58
@github-actions github-actions bot requested a review from eriknordmark January 29, 2025 08:59
@OhmSpectator
Copy link
Member

We will merge it as soon as we fix the master. The PR itself is fine.

@OhmSpectator
Copy link
Member

@rucoder, rebase, please

@rucoder
Add monitor logs to collect-info bundle
2fac642 
- save log for monitor TUI app in collect info bundle

Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
@rucoder rucoder force-pushed the rucoder/monitor-collect-info branch from 6333699 to 2fac642 Compare January 29, 2025 10:32
@OhmSpectator
Copy link
Member

I think you need to rebase on master to get the arm builds to work.

@eriknordmark, the build is fixed

@rene rene dismissed eriknordmark’s stale review January 29, 2025 13:01

PR is already rebased.

@rene rene merged commit 8a92a7f into lf-edge:master Jan 29, 2025
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rene rene rene approved these changes

@OhmSpectator OhmSpectator OhmSpectator approved these changes

@rouming rouming Awaiting requested review from rouming rouming is a code owner

@eriknordmark eriknordmark Awaiting requested review from eriknordmark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rucoder @OhmSpectator @rene @eriknordmark