Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing FW package to installer #4571

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

rucoder
Copy link
Contributor

@rucoder rucoder commented Jan 31, 2025

  • ucode.img is loaded from this package
  • we may need FW to even start the installer on some HW

WARNING: the ISO image is 802MB!!!!

UPDATE: FW adds 160 Mb to the size

- ucode.img is loaded from this package
- we may need FW to even start the installer on some HW
WARNING: the ISO image is 802MB!!!!

Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
@OhmSpectator
Copy link
Member

I think we also want to have this in older LTSes? Mark it as stable then?

@rucoder rucoder added the stable Should be backported to stable release(s) label Jan 31, 2025
@OhmSpectator
Copy link
Member

WARNING: the ISO image is 802MB!!!!

so, what's the gain?... 100%?

@deitch
Copy link
Contributor

deitch commented Jan 31, 2025

Do we need the whole FW for this?

Copy link
Member

@OhmSpectator OhmSpectator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'm not sure it's acceptable for us to double the image size just to deliver a tiny file...

@OhmSpectator
Copy link
Member

Can't we copy just one file by mounting a volume?
Like

volumes:
  - name: mkimage-raw-efi
    image: MKRAW_TAG
    readonly: true
  - name: uboot
    image: UBOOT_TAG
    readonly: true
  - name: ucode
    image: FW_TAG
    readonly: true
    source: /boot/ucode.img

and then

files:
  - path: /boot/ucode.img
    source: ucode

@rucoder
Copy link
Contributor Author

rucoder commented Jan 31, 2025

@OhmSpectator we do not double and we do not deliver ONLY tiny file. we deliver whole missing FW

@rucoder
Copy link
Contributor Author

rucoder commented Jan 31, 2025

Can't we copy just one file by mounting a volume? Like

volumes:
  - name: mkimage-raw-efi
    image: MKRAW_TAG
    readonly: true
  - name: uboot
    image: UBOOT_TAG
    readonly: true
  - name: ucode
    image: FW_TAG
    readonly: true
    source: /boot/ucode.img

and then

files:
  - path: /boot/ucode.img
    source: ucode

no, the whole voluem will be there forever on /container/volumes

@OhmSpectator
Copy link
Member

no, the whole voluem will be there forever on /container/volumes

that's saaad 😔

@OhmSpectator
Copy link
Member

we do not double

What's the final estimation of what we gained that way?

@rucoder
Copy link
Contributor Author

rucoder commented Jan 31, 2025

we do not double

What's the final estimation of what we gained that way?

@OhmSpectator I updated the description

@OhmSpectator
Copy link
Member

WARNING: the ISO image is 802MB!!!!

UPDATE: FW adds 160 Mb to the size

So, 25% weight gain. Not that critical in theory...

@rucoder
Copy link
Contributor Author

rucoder commented Jan 31, 2025

WARNING: the ISO image is 802MB!!!!
UPDATE: FW adds 160 Mb to the size

So, 25% weight gain. Not that critical in theory...

i hope we can shave off some size by installing only zfs tools and not the whole DOM0ZTOOLS

@OhmSpectator OhmSpectator merged commit 54304ff into lf-edge:master Jan 31, 2025
50 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable Should be backported to stable release(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants