-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing FW package to installer #4571
Conversation
- ucode.img is loaded from this package - we may need FW to even start the installer on some HW WARNING: the ISO image is 802MB!!!! Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
I think we also want to have this in older LTSes? Mark it as stable then? |
so, what's the gain?... 100%? |
Do we need the whole FW for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I'm not sure it's acceptable for us to double the image size just to deliver a tiny file...
Can't we copy just one file by mounting a volume? volumes:
- name: mkimage-raw-efi
image: MKRAW_TAG
readonly: true
- name: uboot
image: UBOOT_TAG
readonly: true
- name: ucode
image: FW_TAG
readonly: true
source: /boot/ucode.img and then files:
- path: /boot/ucode.img
source: ucode |
@OhmSpectator we do not double and we do not deliver ONLY tiny file. we deliver whole missing FW |
no, the whole voluem will be there forever on /container/volumes |
that's saaad 😔 |
What's the final estimation of what we gained that way? |
@OhmSpectator I updated the description |
So, 25% weight gain. Not that critical in theory... |
i hope we can shave off some size by installing only zfs tools and not the whole |
WARNING: the ISO image is 802MB!!!!
UPDATE: FW adds 160 Mb to the size
backport to 12.0