Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0-stable] fix: github/workflows/eden.yml: Fix the job name #4584

Merged

Conversation

yash-zededa
Copy link
Collaborator

The platform variants are not back ported to the 12.0-stable branch, so the PR for Eden cannot be directly back ported. This PR addresses the job name and ID to ensure the artifact names are correctly passed to Eden.

The platform variants are not backported to the
12.0-stable branch, so the PR for Eden cannot be
directly backported. This PR addresses the job
name and ID to ensure the artifact names are
correctly passed to Eden.

Signed-off-by: yash-zededa <yash@zededa.com>
@github-actions github-actions bot requested a review from eriknordmark February 3, 2025 20:36
@yash-zededa yash-zededa marked this pull request as ready for review February 3, 2025 20:37
@yash-zededa yash-zededa requested a review from rene February 3, 2025 20:42
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but what do I know)

@eriknordmark eriknordmark changed the title fix: github/workflows/eden.yml: Fix the job name [12.0-stable] fix: github/workflows/eden.yml: Fix the job name Feb 3, 2025
@eriknordmark
Copy link
Contributor

The eden runs fail with
Run actions/download-artifact@v4
with:
github-token: ***
name: eve-kvm-amd64
path: artifacts
merge-multiple: false
repository: lf-edge/eve

So somehow it doesn't get the correct name for the image

to use the github API

Signed-off-by: yash-zededa <yash@zededa.com>
@github-actions github-actions bot requested a review from eriknordmark February 4, 2025 07:04
@yash-zededa
Copy link
Collaborator Author

The artifact run id was null in the get_run_id job. Unable to dowload can be because of that. I have updated get_run_id to use github api better than using the github scripts.

@OhmSpectator OhmSpectator self-requested a review February 4, 2025 08:40
Copy link
Member

@OhmSpectator OhmSpectator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's run the tests again.
Is this commit a backport of some other change that appeared later in 13.*?

@OhmSpectator
Copy link
Member

Ok, at least the tests are working now. Merging

@OhmSpectator OhmSpectator merged commit 8a07a46 into lf-edge:12.0-stable Feb 4, 2025
26 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants