Skip to content

Dependency Management #173

Dependency Management

Dependency Management #173

Triggered via pull request June 2, 2024 20:44
Status Failure
Total duration 51s
Artifacts

check-and-lint.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 98 warnings
written amount is not handled: src/package/target_properties.rs#L188
error: written amount is not handled --> src/package/target_properties.rs:188:9 | 188 | fd.write(self.cmake_include.0.as_ref())?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use `Write::write_all` instead, or handle partial writes = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
written amount is not handled: src/package/management.rs#L126
error: written amount is not handled --> src/package/management.rs:126:9 | 126 | lock_file.write(serialized_json.as_ref())?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use `Write::write_all` instead, or handle partial writes = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount = note: `#[deny(clippy::unused_io_amount)]` on by default
Clippy
Clippy had exited with the 101 exit code
Rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
unused `std::result::Result` that must be used: src/package/management.rs#L186
warning: unused `std::result::Result` that must be used --> src/package/management.rs:186:9 | 186 | fs::create_dir_all(&temporary_path); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: this `Result` may be an `Err` variant, which should be handled help: use `let _ = ...` to ignore the resulting value | 186 | let _ = fs::create_dir_all(&temporary_path); | +++++++
unused `std::result::Result` that must be used: src/package/management.rs#L185
warning: unused `std::result::Result` that must be used --> src/package/management.rs:185:9 | 185 | fs::remove_dir_all(&temporary_path); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: this `Result` may be an `Err` variant, which should be handled help: use `let _ = ...` to ignore the resulting value | 185 | let _ = fs::remove_dir_all(&temporary_path); | +++++++
call to `.clone()` on a reference in this situation does nothing: src/package/lock.rs#L60
warning: call to `.clone()` on a reference in this situation does nothing --> src/package/lock.rs:60:42 | 60 | let temp = lfc_include_folder.clone().join(lock.0); | ^^^^^^^^ | = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed = note: `#[warn(noop_method_call)]` on by default help: remove this redundant call | 60 - let temp = lfc_include_folder.clone().join(lock.0); 60 + let temp = lfc_include_folder.join(lock.0); |
unused `std::result::Result` that must be used: src/backends/mod.rs#L37
warning: unused `std::result::Result` that must be used --> src/backends/mod.rs:37:17 | 37 | app.properties.merge(&library_properties); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: this `Result` may be an `Err` variant, which should be handled = note: `#[warn(unused_must_use)]` on by default help: use `let _ = ...` to ignore the resulting value | 37 | let _ = app.properties.merge(&library_properties); | +++++++
use of `unwrap_or` to construct default value: src/package/mod.rs#L442
warning: use of `unwrap_or` to construct default value --> src/package/mod.rs:442:18 | 442 | .unwrap_or(Vec::new()) | ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
question mark operator is useless here: src/package/mod.rs#L292
warning: question mark operator is useless here --> src/package/mod.rs:292:5 | 292 | Ok(deserializer.deserialize_str(VersioningVisitor)?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `deserializer.deserialize_str(VersioningVisitor)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
question mark operator is useless here: src/package/mod.rs#L268
warning: question mark operator is useless here --> src/package/mod.rs:268:5 | 268 | Ok(serializer.serialize_str(&version.to_string())?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `serializer.serialize_str(&version.to_string())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `#[warn(clippy::needless_question_mark)]` on by default
this `impl` can be derived: src/package/target_properties.rs#L143
warning: this `impl` can be derived --> src/package/target_properties.rs:143:1 | 143 | / impl Default for AppTargetProperties { 144 | | fn default() -> Self { 145 | | Self { 146 | | cmake_include: AutoCmakeLoad::default(), ... | 149 | | } 150 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = help: remove the manual implementation... help: ...and instead derive it | 97 + #[derive(Default)] 98 | pub struct AppTargetProperties { |
this `impl` can be derived: src/package/target_properties.rs#L135
warning: this `impl` can be derived --> src/package/target_properties.rs:135:1 | 135 | / impl Default for LibraryTargetProperties { 136 | | fn default() -> Self { 137 | | Self { 138 | | cmake_include: AutoCmakeLoad::default(), 139 | | } 140 | | } 141 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = help: remove the manual implementation... help: ...and instead derive it | 64 + #[derive(Default)] 65 | pub struct LibraryTargetProperties { |
the borrowed expression implements the required traits: src/package/target_properties.rs#L112
warning: the borrowed expression implements the required traits --> src/package/target_properties.rs:112:49 | 112 | std::fs::read_to_string(&absolute_path) | ^^^^^^^^^^^^^^ help: change this to: `absolute_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
use of `unwrap_or` to construct default value: src/package/target_properties.rs#L115
warning: use of `unwrap_or` to construct default value --> src/package/target_properties.rs:115:22 | 115 | .unwrap_or(String::new()), | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
the borrowed expression implements the required traits: src/package/target_properties.rs#L76
warning: the borrowed expression implements the required traits --> src/package/target_properties.rs:76:49 | 76 | std::fs::read_to_string(&absolute_path) | ^^^^^^^^^^^^^^ help: change this to: `absolute_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
use of `unwrap_or` to construct default value: src/package/target_properties.rs#L79
warning: use of `unwrap_or` to construct default value --> src/package/target_properties.rs:79:22 | 79 | .unwrap_or(String::new()), | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `#[warn(clippy::unwrap_or_default)]` on by default
this `impl` can be derived: src/package/target_properties.rs#L43
warning: this `impl` can be derived --> src/package/target_properties.rs:43:1 | 43 | / impl Default for AutoCmakeLoad { 44 | | fn default() -> Self { 45 | | Self(String::default()) 46 | | } 47 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `#[warn(clippy::derivable_impls)]` on by default = help: remove the manual implementation... help: ...and instead derive it | 41 + #[derive(Default)] 42 | pub struct AutoCmakeLoad(String); |
writing `&String` instead of `&str` involves a new object where a slice will do: src/package/target_properties.rs#L10
warning: writing `&String` instead of `&str` involves a new object where a slice will do --> src/package/target_properties.rs:10:35 | 10 | fn read_file(&mut self, path: &String) -> anyhow::Result<AutoCmakeLoad>; | ^^^^^^^ help: change this to: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
unneeded `return` statement: src/package/tree.rs#L88
warning: unneeded `return` statement --> src/package/tree.rs:88:9 | 88 | return aggregator; | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 88 - return aggregator; 88 + aggregator |
the borrowed expression implements the required traits: src/package/management.rs#L200
warning: the borrowed expression implements the required traits --> src/package/management.rs:200:50 | 200 | let lingo_toml_text = fs::read_to_string(&temporary_path.clone().join("Lingo.toml"))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `temporary_path.clone().join("Lingo.toml")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
writing `&PathBuf` instead of `&Path` involves a new object where a slice will do: src/package/management.rs#L179
warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do --> src/package/management.rs:179:20 | 179 | base_path: &PathBuf, | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg help: change this to | 179 ~ base_path: &Path, 180 | ) -> anyhow::Result<DependencyTreeNode> { 181 | // creating the directory where the library will be housed 182 ~ let library_path = base_path.to_path_buf(); //.join("libs"); |
writing `&String` instead of `&str` involves a new object where a slice will do: src/package/management.rs#L177
warning: writing `&String` instead of `&str` involves a new object where a slice will do --> src/package/management.rs:177:15 | 177 | name: &String, | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg help: change this to | 177 ~ name: &str, 178 | package: PackageDetails, ... 230 | Ok(DependencyTreeNode { 231 ~ name: name.to_owned(), |
using `print!()` with a format string that ends in a single newline: src/package/management.rs#L152
warning: using `print!()` with a format string that ends in a single newline --> src/package/management.rs:152:17 | 152 | print!("{} pulling ...\n", package_name.green().bold()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline help: use `println!` instead | 152 - print!("{} pulling ...\n", package_name.green().bold()); 152 + println!("{} pulling ...", package_name.green().bold()); |
writing `&PathBuf` instead of `&Path` involves a new object where a slice will do: src/package/management.rs#L142
warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do --> src/package/management.rs:142:20 | 142 | root_path: &PathBuf, | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg help: change this to | 142 ~ root_path: &Path, 143 | ) -> anyhow::Result<Vec<DependencyTreeNode>> { 144 | let mut sub_dependencies = vec![]; 145 | self.pulling_queue.append(&mut dependencies); 146 ~ let sub_dependency_path = root_path.to_path_buf().join("libraries"); |
unneeded `return` statement: src/package/management.rs#L136
warning: unneeded `return` statement --> src/package/management.rs:136:9 | 136 | return Ok(manager); | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 136 - return Ok(manager); 136 + Ok(manager) |
you should consider adding a `Default` implementation for `DependencyManager`: src/package/management.rs#L77
warning: you should consider adding a `Default` implementation for `DependencyManager` --> src/package/management.rs:77:5 | 77 | / pub fn new() -> DependencyManager { 78 | | Self { 79 | | pulling_queue: Default::default(), 80 | | lock: DependencyLock::new(), 81 | | } 82 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default help: try adding this | 76 + impl Default for DependencyManager { 77 + fn default() -> Self { 78 + Self::new() 79 + } 80 + } |
unneeded `return` statement: src/package/lock.rs#L112
warning: unneeded `return` statement --> src/package/lock.rs:112:9 | 112 | return Ok(i); | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 112 - return Ok(i); 112 + Ok(i) |
writing `&PathBuf` instead of `&Path` involves a new object where a slice will do: src/package/lock.rs#L90
warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do --> src/package/lock.rs:90:22 | 90 | source_path: &PathBuf, | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default help: change this to | 90 ~ source_path: &Path, 91 | target_path: &PathBuf, ... 95 | for (name, lock) in self.package_locations.iter() { 96 ~ let local_source = source_path.to_path_buf().join(lock.hash.clone()); |
unneeded `return` statement: src/package/lock.rs#L103
warning: unneeded `return` statement --> src/package/lock.rs:103:9 | 103 | return Ok(()); | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 103 - return Ok(()); 103 + Ok(()) |
using `print!()` with a format string that ends in a single newline: src/package/lock.rs#L62
warning: using `print!()` with a format string that ends in a single newline --> src/package/lock.rs:62:13 | 62 | / print!( 63 | | "{} reading ... {}\n", 64 | | lock.0.to_string().green().bold(), 65 | | &temp.display() 66 | | ); | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline = note: `#[warn(clippy::print_with_newline)]` on by default help: use `println!` instead | 62 ~ println!( 63 ~ "{} reading ... {}", |
you should consider adding a `Default` implementation for `DependencyLock`: src/package/lock.rs#L26
warning: you should consider adding a `Default` implementation for `DependencyLock` --> src/package/lock.rs:26:5 | 26 | / pub fn new() -> DependencyLock { 27 | | Self { 28 | | package_locations: HashMap::new(), 29 | | loaded_dependencies: Vec::new(), 30 | | } 31 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 25 + impl Default for DependencyLock { 26 + fn default() -> Self { 27 + Self::new() 28 + } 29 + } |
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`: src/backends/mod.rs#L24
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/backends/mod.rs:24:5 | 24 | / match command { 25 | | CommandSpec::Build(build) => { 26 | | let manager = DependencyManager::from_dependencies( 27 | | dependencies.clone(), ... | 40 | | _ => {} 41 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default help: try | 24 ~ if let CommandSpec::Build(build) = command { 25 + let manager = DependencyManager::from_dependencies( 26 + dependencies.clone(), 27 + &PathBuf::from("./target"), 28 + ) 29 + .expect("failed to create dep manager"); 30 + 31 + // enriching the apps with the target properties from the libraries 32 + let library_properties = manager.get_target_properties().expect("lib properties"); 33 + 34 + // merging app with library target properties 35 + for app in &mut config.apps { 36 + app.properties.merge(&library_properties); 37 + } 38 + } |
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: src/backends/mod.rs#L22
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/backends/mod.rs:22:39 | 22 | let dependencies = Vec::from_iter(config.dependencies.clone().into_iter()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `config.dependencies.clone()` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/iter/traits/collect.rs:150:21 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
variant `NotCombineableTargetProperties` is never constructed: src/util/errors.rs#L21
warning: variant `NotCombineableTargetProperties` is never constructed --> src/util/errors.rs:21:5 | 12 | pub enum LingoError { | ---------- variant in this enum ... 21 | NotCombineableTargetProperties(String), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `LingoError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
function `merge` is never used: src/package/target_properties.rs#L122
warning: function `merge` is never used --> src/package/target_properties.rs:122:4 | 122 | fn merge<T>( | ^^^^^
associated function `new` is never used: src/package/tree.rs#L53
warning: associated function `new` is never used --> src/package/tree.rs:53:19 | 52 | impl DependencyTreeNode { | ----------------------- associated function in this implementation 53 | pub(crate) fn new() -> DependencyTreeNode { | ^^^
associated constant `DEFAULT_MAIN_REACTOR_RELPATH` is never used: src/package/mod.rs#L312
warning: associated constant `DEFAULT_MAIN_REACTOR_RELPATH` is never used --> src/package/mod.rs:312:11 | 310 | impl ConfigFile { | --------------- associated constant in this implementation 311 | // FIXME: The default should be that it searches the `src` directory for a main reactor 312 | const DEFAULT_MAIN_REACTOR_RELPATH: &'static str = "src/Main.lf"; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
type `package::management::LocationDescription` is more private than the item `package::management::DependencyManager::flatten`: src/package/management.rs#L241
warning: type `package::management::LocationDescription` is more private than the item `package::management::DependencyManager::flatten` --> src/package/management.rs:241:5 | 241 | / pub fn flatten( 242 | | root_nodes: Vec<DependencyTreeNode>, 243 | | ) -> anyhow::Result<HashMap<String, LocationDescription>> { | |_____________________________________________________________^ associated function `package::management::DependencyManager::flatten` is reachable at visibility `pub` | note: but type `package::management::LocationDescription` is only usable at visibility `pub(crate)` --> src/package/management.rs:25:1 | 25 | pub(crate) struct LocationDescription { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
type `package::management::LocationDescription` is more private than the item `package::lock::DependencyLock::from`: src/package/lock.rs#L33
warning: type `package::management::LocationDescription` is more private than the item `package::lock::DependencyLock::from` --> src/package/lock.rs:33:5 | 33 | / pub fn from( 34 | | mut unlocked_locations: HashMap<String, LocationDescription>, 35 | | loaded_dependencies: Vec<DependencyTreeNode>, 36 | | ) -> DependencyLock { | |_______________________^ associated function `package::lock::DependencyLock::from` is reachable at visibility `pub` | note: but type `package::management::LocationDescription` is only usable at visibility `pub(crate)` --> src/package/management.rs:25:1 | 25 | pub(crate) struct LocationDescription { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = note: `#[warn(private_interfaces)]` on by default
unused variable: `e`: src/package/mod.rs#L284
warning: unused variable: `e` --> src/package/mod.rs:284:42 | 284 | Versioning::from_str(v).map_err(|e| E::custom("not a valid version {e}")) | ^ ------------------------- you might have meant to use string interpolation in this string literal | | | unused variable | help: string interpolation only works in `format!` invocations | 284 | Versioning::from_str(v).map_err(|e| E::custom(format!("not a valid version {e}"))) | ++++++++ + help: if this is intentional, prefix it with an underscore | 284 | Versioning::from_str(v).map_err(|_e| E::custom("not a valid version {e}")) | ~~
variable does not need to be mutable: src/package/management.rs#L221
warning: variable does not need to be mutable --> src/package/management.rs:221:13 | 221 | let mut dependencies = vec![]; | ----^^^^^^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default
unused variable: `dependencies`: src/backends/mod.rs#L132
warning: unused variable: `dependencies` --> src/backends/mod.rs:132:35 | 132 | fn for_apps(apps: &[&'a App], dependencies: Vec<(String, PackageDetails)>) -> Self { | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_dependencies`
unused variable: `build`: src/backends/mod.rs#L25
warning: unused variable: `build` --> src/backends/mod.rs:25:28 | 25 | CommandSpec::Build(build) => { | ^^^^^ help: if this is intentional, prefix it with an underscore: `_build` | = note: `#[warn(unused_variables)]` on by default
unused import: `std::hash::Hash`: src/package/tree.rs#L3
warning: unused import: `std::hash::Hash` --> src/package/tree.rs:3:5 | 3 | use std::hash::Hash; | ^^^^^^^^^^^^^^^
use of deprecated function `<args::CommandLineArgs as clap::Args>::augment_args::bare_action`: `#[arg(action)]` is now the default and is no longer needed`: src/args.rs#L137
warning: use of deprecated function `<args::CommandLineArgs as clap::Args>::augment_args::bare_action`: `#[arg(action)]` is now the default and is no longer needed` --> src/args.rs:137:25 | 137 | #[clap(short, long, action)] | ^^^^^^
use of deprecated function `<args::CommandLineArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`: src/args.rs#L137
warning: use of deprecated function `<args::CommandLineArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> src/args.rs:137:7 | 137 | #[clap(short, long, action)] | ^^^^
use of deprecated function `<args::CommandLineArgs as clap::Args>::augment_args::bare_action`: `#[arg(action)]` is now the default and is no longer needed`: src/args.rs#L133
warning: use of deprecated function `<args::CommandLineArgs as clap::Args>::augment_args::bare_action`: `#[arg(action)]` is now the default and is no longer needed` --> src/args.rs:133:25 | 133 | #[clap(short, long, action)] | ^^^^^^
use of deprecated function `<args::CommandLineArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`: src/args.rs#L133
warning: use of deprecated function `<args::CommandLineArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> src/args.rs:133:7 | 133 | #[clap(short, long, action)] | ^^^^
use of deprecated function `<args::CommandLineArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[command(...)]`: src/args.rs#L126
warning: use of deprecated function `<args::CommandLineArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[command(...)]` --> src/args.rs:126:3 | 126 | #[clap(about = "Build system for the Lingua Franca coordination language", long_about = None)] | ^^^^
use of deprecated function `<args::CommandLineArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[command(...)]`: src/args.rs#L125
warning: use of deprecated function `<args::CommandLineArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[command(...)]` --> src/args.rs:125:3 | 125 | #[clap(version = env!("CARGO_PKG_VERSION"))] | ^^^^
use of deprecated function `<args::CommandLineArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[command(...)]`: src/args.rs#L124
warning: use of deprecated function `<args::CommandLineArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[command(...)]` --> src/args.rs:124:3 | 124 | #[clap(author = "tassilo.tanneberger@tu-dresden.de")] | ^^^^
use of deprecated function `<args::CommandLineArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[command(...)]`: src/args.rs#L123
warning: use of deprecated function `<args::CommandLineArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[command(...)]` --> src/args.rs:123:3 | 123 | #[clap(name = "Lingua Franca package manager and build tool")] | ^^^^
use of deprecated function `<args::InitArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`: src/args.rs#L86
warning: use of deprecated function `<args::InitArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> src/args.rs:86:7 | 86 | #[clap(value_enum, short, long, default_value_t = Platform::Native)] | ^^^^
use of deprecated function `<args::InitArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`: src/args.rs#L84
warning: use of deprecated function `<args::InitArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> src/args.rs:84:7 | 84 | #[clap(value_enum, short, long)] | ^^^^
use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`: src/args.rs#L68
warning: use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> src/args.rs:68:7 | 68 | #[clap(short, long, default_value_t = 0)] | ^^^^
use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`: src/args.rs#L64
warning: use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> src/args.rs:64:7 | 64 | #[clap(short, long, value_delimiter = ',')] | ^^^^
use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::bare_action`: `#[arg(action)]` is now the default and is no longer needed`: src/args.rs#L60
warning: use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::bare_action`: `#[arg(action)]` is now the default and is no longer needed` --> src/args.rs:60:25 | 60 | #[clap(short, long, action)] | ^^^^^^
use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`: src/args.rs#L60
warning: use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> src/args.rs:60:7 | 60 | #[clap(short, long, action)] | ^^^^
use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::bare_action`: `#[arg(action)]` is now the default and is no longer needed`: src/args.rs#L56
warning: use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::bare_action`: `#[arg(action)]` is now the default and is no longer needed` --> src/args.rs:56:25 | 56 | #[clap(short, long, action)] | ^^^^^^
use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`: src/args.rs#L56
warning: use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> src/args.rs:56:7 | 56 | #[clap(short, long, action)] | ^^^^
use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::bare_action`: `#[arg(action)]` is now the default and is no longer needed`: src/args.rs#L52
warning: use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::bare_action`: `#[arg(action)]` is now the default and is no longer needed` --> src/args.rs:52:25 | 52 | #[clap(short, long, action)] | ^^^^^^
use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`: src/args.rs#L48
warning: use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> src/args.rs:48:7 | 48 | #[clap(long)] | ^^^^
use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`: src/args.rs#L44
warning: use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> src/args.rs:44:7 | 44 | #[clap(long)] | ^^^^
use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`: src/args.rs#L40
warning: use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> src/args.rs:40:7 | 40 | #[clap(short, long)] | ^^^^
use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`: src/args.rs#L36
warning: use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> src/args.rs:36:7 | 36 | #[clap(short, long)] | ^^^^
use of deprecated function `<args::TargetLanguage as clap::ValueEnum>::to_possible_value::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[value(...)]`: src/args.rs#L7
warning: use of deprecated function `<args::TargetLanguage as clap::ValueEnum>::to_possible_value::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[value(...)]` --> src/args.rs:7:3 | 7 | #[clap(rename_all = "lowercase")] | ^^^^ | = note: `#[warn(deprecated)]` on by default
unused import: `DeserializeSeed`: src/package/mod.rs#L21
warning: unused import: `DeserializeSeed` --> src/package/mod.rs:21:17 | 21 | use serde::de::{DeserializeSeed, Error, Visitor}; | ^^^^^^^^^^^^^^^
unused import: `Deserializer`: src/package/target_properties.rs#L3
warning: unused import: `Deserializer` --> src/package/target_properties.rs:3:26 | 3 | use serde::{Deserialize, Deserializer, Serialize, Serializer}; | ^^^^^^^^^^^^
unused imports: `DeserializeSeed`, `Error`, `Visitor`: src/package/target_properties.rs#L2
warning: unused imports: `DeserializeSeed`, `Error`, `Visitor` --> src/package/target_properties.rs:2:17 | 2 | use serde::de::{DeserializeSeed, Error, Visitor}; | ^^^^^^^^^^^^^^^ ^^^^^ ^^^^^^^
unused import: `serde::de::Unexpected::Str`: src/package/target_properties.rs#L1
warning: unused import: `serde::de::Unexpected::Str` --> src/package/target_properties.rs:1:5 | 1 | use serde::de::Unexpected::Str; | ^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `debug`: src/package/management.rs#L14
warning: unused import: `debug` --> src/package/management.rs:14:11 | 14 | use log::{debug, error}; | ^^^^^
unused import: `git2::ErrorCode::HashsumMismatch`: src/package/management.rs#L13
warning: unused import: `git2::ErrorCode::HashsumMismatch` --> src/package/management.rs:13:5 | 13 | use git2::ErrorCode::HashsumMismatch; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused imports: `AppTargetProperties`, `GenericTargetProperties`, `MergeTargetProperties`: src/package/management.rs#L5
warning: unused imports: `AppTargetProperties`, `GenericTargetProperties`, `MergeTargetProperties` --> src/package/management.rs:5:5 | 5 | AppTargetProperties, GenericTargetProperties, LibraryTargetProperties, MergeTargetProperties, | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
Clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Check
unused manifest key: bin.0.publish
Check: src/package/management.rs#L5
unused imports: `AppTargetProperties`, `GenericTargetProperties`, `MergeTargetProperties`
Check: src/package/management.rs#L13
unused import: `git2::ErrorCode::HashsumMismatch`
Check: src/package/management.rs#L14
unused import: `debug`
Check: src/package/target_properties.rs#L1
unused import: `serde::de::Unexpected::Str`
Check: src/package/target_properties.rs#L2
unused imports: `DeserializeSeed`, `Error`, `Visitor`
Check: src/package/target_properties.rs#L3
unused import: `Deserializer`
Check: src/package/mod.rs#L21
unused import: `DeserializeSeed`
Check: src/args.rs#L7
use of deprecated function `<args::TargetLanguage as clap::ValueEnum>::to_possible_value::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[value(...)]`
Check: src/args.rs#L36
use of deprecated function `<args::BuildArgs as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/