Librarify #80
Clippy Output
7 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 7 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.81.0 (eeb90cda1 2024-09-04)
- cargo 1.81.0 (2dbb1af80 2024-08-20)
- clippy 0.1.81 (eeb90cd 2024-09-04)
Annotations
Check warning on line 152 in src/main.rs
github-actions / Clippy Output
unused variable: `apps`
warning: unused variable: `apps`
--> src/main.rs:152:9
|
152 | let apps = config.apps.iter().collect::<Vec<_>>();
| ^^^^ help: if this is intentional, prefix it with an underscore: `_apps`
Check warning on line 100 in src/main.rs
github-actions / Clippy Output
unused variable: `which_capability`
warning: unused variable: `which_capability`
--> src/main.rs:100:81
|
100 | ...d: ConsoleCommand, which_capability: WhichCapability, git_clone_capability: GitCloneCapability) -> CommandResult<'a> {
| ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_which_capability`
|
= note: `#[warn(unused_variables)]` on by default
Check warning on line 107 in src/package/management.rs
github-actions / Clippy Output
passing a unit value to a function
warning: passing a unit value to a function
--> src/package/management.rs:99:17
|
99 | / Ok(match reference {
100 | | // gref is an actual reference like branches or tags
101 | | Some(gref) => {
102 | | self.git_rev = gref.target().map(|v| v.to_string());
... |
106 | | None => repo.set_head_detached(object.id())?,
107 | | })
| |__________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
= note: `#[warn(clippy::unit_arg)]` on by default
help: move the expression in front of the call and replace it with the unit literal `()`
|
99 ~ match reference {
100 + // gref is an actual reference like branches or tags
101 + Some(gref) => {
102 + self.git_rev = gref.target().map(|v| v.to_string());
103 + repo.set_head(gref.name().unwrap())?
104 + }
105 + // this is a commit, not a reference
106 + None => repo.set_head_detached(object.id())?,
107 + };
108 + Ok(())
|
Check warning on line 23 in src/backends/mod.rs
github-actions / Clippy Output
unused variable: `clone`
warning: unused variable: `clone`
--> src/backends/mod.rs:23:99
|
23 | ...nfig, which: WhichCapability, clone: GitCloneCapability) -> BatchBuildResults<'a> {
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_clone`
|
= note: `#[warn(unused_variables)]` on by default
Check warning on line 1 in src/util/mod.rs
github-actions / Clippy Output
unused import: `which::which`
warning: unused import: `which::which`
--> src/util/mod.rs:1:5
|
1 | use which::which;
| ^^^^^^^^^^^^
Check warning on line 14 in src/package/mod.rs
github-actions / Clippy Output
unused import: `which::which`
warning: unused import: `which::which`
--> src/package/mod.rs:14:5
|
14 | use which::which;
| ^^^^^^^^^^^^
Check warning on line 7 in src/package/mod.rs
github-actions / Clippy Output
unused import: `git2::Repository`
warning: unused import: `git2::Repository`
--> src/package/mod.rs:7:5
|
7 | use git2::Repository;
| ^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default