Stringify CMake command-line arguments before they are added as compile definitions #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlingrj
changed the title
edwardalee
approved these changes
Jan 22, 2025
| cmake-init-include |
There was a problem hiding this comment.
Reset to master when merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for: lf-lang/lingua-franca#2432
The paths to the source directory, binary directory and src-gen directory are passed to CMake as command line arguments. They are originally passed as strings using quotation marks. In the LF change linked I remove the quotation marks because it means you cannot easily use them in CMake. I think these paths are most useful for the user when he adds a cmake-include.
So in this PR I add quotation marks to the paths before they are made into compile definitions so that they conveniently can be used in the user C code as well.