-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RIOT federated CoAP TEST #189
Conversation
The next step is to let the CI execute this and add a small test case that fails if the receiver does not receive the |
Benchmark results after merging this PR: Benchmark resultsPerformance:PingPongUc: PingPongC: ReactionLatencyUc: ReactionLatencyC: Memory usage:PingPongUc: PingPongC: ReactionLatencyUc: ReactionLatencyC: |
Memory usage after merging this PR will be: Memory Reportaction_empty_test_c
action_microstep_test_c
action_overwrite_test_c
action_test_c
deadline_test_c
delayed_conn_test_c
event_payload_pool_test_c
event_queue_test_c
nanopb_test_c
port_test_c
reaction_queue_test_c
request_shutdown_test_c
startup_test_c
tcp_channel_test_c
timer_test_c
|
Looks promising. It would be really great to understand what this race condition in the startup is about. Adding explicit sleeps to enforce some ordering often works great until we have some freak CI run where the timing is completely messed up because it is running in the cloud and maybe the CI task was suspended at the wrong point etc... |
36a6fac
to
851f513
Compare
55d56c3
to
c4360c5
Compare
Okay this is pretty much done. The only problem that remains is that I am having issues setting up the tap interfaces in the CI. I will look more into it |
Holy f** the CI has finally passed :D |
Finally I got the tap interfaces working in the CI, this is ready for review!! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THis looks great! Added a commit fixing the example program. And a few comments
Okay I think all the feedback is addressed, thank you! |
No real test yet, but at least I finally managed to run the sender and the receiver in parallel from one script file.
I had a strange race condition in RIOT perhaps? The sender and receiver were unable to talk over the tap interface, if they started to fast in parallel.
The solution for now is:
sleep 3
.... But it wörks :)