Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate (federated | delayed) connection.is_physical to ENUM #91

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

LasseRosenow
Copy link
Collaborator

Similar to my feedback on the Action.is_physical I also updated the DelayedConnection and FederatedConnection to use an ENUM instead of the is_physical boolean.

I am not sure if maybe the Kotlin Compiler needs to be adapted to this and I am not confident in that area yet, so I left it out for now

Copy link
Contributor

Memory usage after merging this PR will be:

Memory Report

action_microstep_test_c

from to increase (%)
text 39461 39461 0.00
data 744 744 0.00
bss 480 480 0.00
total 40685 40685 0.00

action_test_c

from to increase (%)
text 39250 39250 0.00
data 744 744 0.00
bss 480 480 0.00
total 40474 40474 0.00

delayed_conn_test_c

from to increase (%)
text 42719 42716 -0.01
data 736 736 0.00
bss 480 480 0.00
total 43935 43932 -0.01

event_payload_pool_test_c

from to increase (%)
text 18297 18297 0.00
data 624 624 0.00
bss 320 320 0.00
total 19241 19241 0.00

event_queue_test_c

from to increase (%)
text 26242 26242 0.00
data 720 720 0.00
bss 480 480 0.00
total 27442 27442 0.00

physical_action_test_c

from to increase (%)
text 40463 40463 0.00
data 761 761 0.00
bss 2016 2016 0.00
total 43240 43240 0.00

port_test_c

from to increase (%)
text 42594 42591 -0.01
data 736 736 0.00
bss 480 480 0.00
total 43810 43807 -0.01

reaction_queue_test_c

from to increase (%)
text 25906 25906 0.00
data 720 720 0.00
bss 480 480 0.00
total 27106 27106 0.00

shutdown_test_c

from to increase (%)
text 36731 36731 0.00
data 744 744 0.00
bss 2688 2688 0.00
total 40163 40163 0.00

startup_test_c

from to increase (%)
text 36062 36062 0.00
data 744 744 0.00
bss 2464 2464 0.00
total 39270 39270 0.00

timer_test_c

from to increase (%)
text 36248 36248 0.00
data 736 736 0.00
bss 480 480 0.00
total 37464 37464 0.00

@erlingrj
Copy link
Collaborator

Great, for now I disable the LF tests because we wont waste time working on the code-generator until the APIs have stabilized

Copy link
Contributor

Memory usage after merging this PR will be:

Memory Report

action_microstep_test_c

from to increase (%)
text 39461 39461 0.00
data 744 744 0.00
bss 480 480 0.00
total 40685 40685 0.00

action_test_c

from to increase (%)
text 39250 39250 0.00
data 744 744 0.00
bss 480 480 0.00
total 40474 40474 0.00

delayed_conn_test_c

from to increase (%)
text 42719 42716 -0.01
data 736 736 0.00
bss 480 480 0.00
total 43935 43932 -0.01

event_payload_pool_test_c

from to increase (%)
text 18297 18297 0.00
data 624 624 0.00
bss 320 320 0.00
total 19241 19241 0.00

event_queue_test_c

from to increase (%)
text 26242 26242 0.00
data 720 720 0.00
bss 480 480 0.00
total 27442 27442 0.00

physical_action_test_c

from to increase (%)
text 40463 40463 0.00
data 761 761 0.00
bss 2016 2016 0.00
total 43240 43240 0.00

port_test_c

from to increase (%)
text 42594 42591 -0.01
data 736 736 0.00
bss 480 480 0.00
total 43810 43807 -0.01

reaction_queue_test_c

from to increase (%)
text 25906 25906 0.00
data 720 720 0.00
bss 480 480 0.00
total 27106 27106 0.00

shutdown_test_c

from to increase (%)
text 36731 36731 0.00
data 744 744 0.00
bss 2688 2688 0.00
total 40163 40163 0.00

startup_test_c

from to increase (%)
text 36062 36062 0.00
data 744 744 0.00
bss 2464 2464 0.00
total 39270 39270 0.00

timer_test_c

from to increase (%)
text 36248 36248 0.00
data 736 736 0.00
bss 480 480 0.00
total 37464 37464 0.00

Copy link
Contributor

Coverage after merging change-is-physical-to-enums into main will be

33.53%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
external/nanopb
   pb_common.c0%0%0%0%100, 100, 100, 100, 100, 102, 106, 110, 110, 110, 110, 110, 112, 116, 119, 122, 124, 126, 126, 126, 129–132, 14, 14, 14, 142–144, 15, 150–152, 152, 152, 152, 152, 154, 156, 158, 160–161, 163, 166, 168, 17, 171–172, 172, 172, 177, 18, 181, 184–185, 188, 190–192, 195, 197, 197, 197, 199, 20, 20, 20, 20, 20, 201, 201, 201, 203, 207, 210, 210, 210, 215, 22, 221, 224, 226, 226, 226, 229, 231, 231, 231–232, 232, 232, 235, 238, 238, 238, 24, 241–242, 246, 248, 248, 248, 25, 250, 254, 26, 260, 263, 265, 265, 265, 267, 269, 269, 269, 27, 272–273, 277, 28, 286–287, 29, 290, 292, 295, 297, 300, 302, 302, 302, 304, 306, 306, 306, 308, 308, 308, 308, 308, 310, 313, 313, 313, 313, 313, 315, 32, 320, 34, 36–41, 44, 46–48, 50–55, 58, 60–63, 65–70, 74, 74, 74, 77–78, 8, 82, 84, 84, 84, 86, 88, 88, 88–89, 89, 89–90, 90, 90, 93, 97
   pb_decode.c0%0%0%0%100, 1000–1001, 1003–1004, 1007, 1007, 1007, 1009, 1009, 1009, 1011, 1011, 1011–1012, 1012, 1012, 1016, 1016, 1016, 1022, 1022, 1022, 1024, 1024, 1024–1025, 1027, 1030, 1030, 1030, 1032, 1032, 1032, 1034, 1038, 1038, 1038, 104, 104, 104, 1042, 1042, 1042, 1042, 1042, 1045, 1045, 1045, 1047, 1047, 1047, 1049, 105, 105, 105, 1050, 1053, 1053, 1053, 1055, 1059, 1059, 1059, 1061, 1063, 1063, 1063–1064, 1066, 1066, 1066, 1069, 1074, 1074, 1074–1076, 108, 108, 108, 1082, 1082, 1082, 1082, 1082, 1084, 1084, 1084, 1089, 1089, 1089, 109, 109, 109, 1090, 1090, 1090, 1092, 1092, 1092, 1095–1097, 1100, 1103, 1103, 1103–1104, 1104, 1104, 1106–1107, 1110, 1110, 1110–1111, 1115, 1115, 1115–1116, 1116, 1116, 1118, 1118, 1118, 1123, 1125, 1125, 1125, 1129, 1129, 1129–1130, 1133, 1133, 1133, 1135, 1135, 1135–1136, 1136, 1136, 1140, 1140, 1140, 1142–1143, 1143, 1143, 1145, 1145, 1145, 115, 115, 115, 1151, 1154, 1158, 1158, 1158, 116, 1160, 1165, 1165, 1165–1166, 1168, 1170, 1170, 1170–1171, 1179, 118, 1182, 1186, 1193, 120, 125, 127, 127, 127–128, 128, 128, 131, 131, 131–132, 132, 132, 1336, 1341, 1346, 1349, 1349, 1349–1350, 1352–1353, 1356, 1359, 1359, 1359–1360, 1362, 1362, 1362–1363, 1365, 1367, 1370, 1377, 1377, 1377–1378, 138, 1382, 1389, 1393, 140, 1400, 1400, 1400–1401, 1405, 1416, 1420, 1422, 1425, 1427, 1427, 1427, 143, 1430, 1430, 1430–1431, 1434, 1434, 1434–1436, 1436, 1436–1438, 1438, 1438–1440, 1440, 1440–1441, 1443, 1443, 1443, 1445, 1445, 1445–1446, 1446, 1446, 1448, 1456, 1456, 1456, 1458, 1458, 1458–1459, 1463, 1463, 1463–1464, 1472, 1472, 1472–1473, 1475, 1479, 1479, 1479–1481, 1481, 1481–1483, 1483, 1483–1485, 1485, 1485–1486, 1488, 1488, 1488, 1490, 1490, 1490–1491, 1491, 1491, 1493, 1497, 1503, 1503, 1503–1504, 1506, 1506, 1506–1507, 1507, 1507, 1509–1510, 1510, 1510–1511, 1511, 1511, 1513, 1513, 1513, 1516, 1516, 1516, 1528, 1528, 1528–1529, 1529, 1529–1530, 1533–1534, 1537, 1541, 1543, 1543, 1543–1544, 1546, 1546, 1546–1547, 1547, 1547, 1550, 1552, 1552, 1552–1553, 1553, 1553, 1555,

@erlingrj erlingrj merged commit 66fb853 into main Oct 23, 2024
2 checks passed
@erlingrj erlingrj deleted the change-is-physical-to-enums branch October 25, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants