Simplify the code and support Pytest 8 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* python: 3.10, 3.11, 3.12 * cython: 0.29, 3 * pytest: 8
* python: 3.10, 3.11, 3.12 * cython: 0.28, 3 * pytest: 8 * import mode: importlib
* move the adding of line numbers to its own method
|
@embray if you have a gap would you mind reviewing this? |
nsoranzo
reviewed
Apr 2, 2024
| @property | ||
| def purebasename(self): | ||
| return super().basename.replace(EXT_SUFFIX, '') | ||
| def _without_suffixes(path: str | pathlib.Path) -> pathlib.Path: |
There was a problem hiding this comment.
Hi, the use of | for the type annotation breaks code using this plugin on Python 3.8 and 3.9 (both still supported by pytest), see https://docs.python.org/3/library/typing.html#typing.Union
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61
Fixes #58
Fixes #59