feat: add support for astropy >=6.1.7<8 dependency in pyproject.yaml #36
Conversation
michealroberts
force-pushed
the
feature/dependency/astropy
branch
4 times, most recently
from
8258c8e to
5dd57e7
Compare
| @@ -1,10 +1,20 @@ | |||
| FROM python:3.11-buster | |||
There was a problem hiding this comment.
@lgrcia Buster is now obsolete, bookworm seems to cover 3.11.11 -> 3.13.1. (see https://hub.docker.com/_/python)
| @@ -14,8 +14,8 @@ repository = "https://github.com/lgrcia/twirl" | |||
| keywords = ["astronomy", "astrometry", "plate-solving"] | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "^3.9" | |||
| astropy = "^5.1.1" | |||
| python = ">=3.11,<3.14" | |||
There was a problem hiding this comment.
Pinning to greater than python 3.11 here, as there was a discrepancy between the Dockerfile at 3.11-buster and the version here in the pyproject.toml file.
.github/workflows/ci.yml
Outdated
| os: [ ubuntu-latest ] | ||
| os: [ubuntu-latest] | ||
| python-version: ["3.11", "3.12", "3.13"] | ||
| astropy-version: ["5.1.1", "6.1.7", "7.0"] |
There was a problem hiding this comment.
Ensure we "test" against all three major versions of astropy.
michealroberts
force-pushed
the
feature/dependency/astropy
branch
2 times, most recently
from
f12b186 to
dae6712
Compare
feat: add support for astropy >=6.1.7<8 dependency in pyproject.yaml
michealroberts
force-pushed
the
feature/dependency/astropy
branch
from
dae6712 to
ff5ede7
Compare
michealroberts
changed the title
|
@lgrcia Due to some PEP 517 build issues, it might be easier to go straight to version 6 and 7 support in the next release ... This would probably make the version a breaking change, unless you're happy to bump in 0.*.0 breaking changes (which is permissible under semver guidelines). |
|
Is this PR stalled? I would like to try Twirl, but I already use astropy 7. |
|
@lgrcia Pinging again on this one. |
|
Sorry for the huge delay and thanks so much for the PR @michealroberts! I guess we are pretty dependent on astropy so it makes sense to have these tests. Could we keep the compatibility with Python 3.10? |
|
Is it a strong requirement? Python 3.10 is quite old already (release in 2021)... @michealroberts what do you think? |
|
@onekiloparsec It's only 3 minor versions ago ... I usually see libraries atm support back to 3.6 if they can ... but for me, I would deprecate early and rip the band aid off ... |
|
@lgrcia I should have said, astropy v7.. (as far as I am ware) is not version 3.10 compatible ... but my memory is hazy. |
|
@lgrcia Confirmed on the pypi for astropy version 7: https://pypi.org/project/astropy/ 
|
|
Just checked, for reference:
|
feat: add support for astropy >=6.1.7,<8 dependency in pyproject.yaml
Includes addition support for testings against a matrix of the most recent astropy versions across 6 to 7 by maintaining test support for latest versions of each 6 to 7, i.e., currently
6.1.7and7.0.0.Closes #35