xglobals,xprecompiled: Avoid <ntdef.h>

In Microsoft Windows SDK there are duplicate definitions which cause compiler
errors when built with clang-cl. `RTL_CONSTANT_STRING` is necessary so we
define our own.

(cherry picked from commit a273c6e)
Signed-off-by: LIU Hao <lh_mouse@126.com>

mcfgthread/xglobals.c

@@ -179,7 +179,7 @@ __MCF_gthread_initialize_globals(void)
 
     /* Generate the unique name for this process.  */
     static WCHAR gnbuffer[] = L"Local\\__MCF_crt_xglobals_*?pid???_#?cookie????????";
-    UNICODE_STRING gname = RTL_CONSTANT_STRING(gnbuffer);
+    UNICODE_STRING gname = __MCF_NT_STRING_INIT(gnbuffer);
     __MCF_ASSERT(gnbuffer[25] == L'*');
     ULONG pid = GetCurrentProcessId();
     do_encode_numeric_field(gnbuffer + 25, 8, pid, L"0123456789ABCDEF");

mcfgthread/xglobals.h

@@ -17,7 +17,6 @@
 #include <winnt.h>
 #include <winternl.h>
 #include <winerror.h>
-#include <ntdef.h>
 #include <sysinfoapi.h>
 #include <profileapi.h>
 #include <realtimeapiset.h>
@@ -73,6 +72,14 @@ NTSYSAPI ULONG NTAPI RtlNtStatusToDosErrorNoTeb(NTSTATUS status) __MCF_FN_CONST;
  * the `.bss` section.  */
 #define __MCF_BAD_PTR  ((void*) -127)
 
+/* Define a macro that is identical to `RTL_CONSTANT_STRING()` as we are not
+ * willing to include <ntdef.h> here.  */
+#define __MCF_NT_STRING_INIT(s)  \
+    { .Length = sizeof(s) - sizeof(*(s)),  \
+      .MaximumLength = sizeof(s),  \
+      .Buffer = (void*) ((s) + __MCF_STATIC_ASSERT_0(  \
+         !__builtin_types_compatible_p(__typeof__(1+&*(s)), __typeof__(s))))  }
+
 /* Define macros and types for lazy binding.
  * If a symbol cannot be found during startup, it is set to a null pointer.  */
 #define __MCF_G_LAZY_FIELD(name)   decltype_##name* __f_##name

mcfgthread/xprecompiled.h

@@ -20,7 +20,6 @@
 #include <winnt.h>
 #include <winternl.h>
 #include <winerror.h>
-#include <ntdef.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <stdbool.h>