Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add build-test option #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build: add build-test option #259

wants to merge 1 commit into from

Conversation

star-hengxing
Copy link

No description provided.

@lhmouse
Copy link
Owner

lhmouse commented Sep 9, 2024

There are two issues with this commit:

  1. The preferred name for this option would be enable-tests or with-tests (use plural!). The former is usually preferred.
  2. Tests should not be disabled by default. Ideally we should have build_by_default: false on tests, but it does not do what it seems to be:
    (test executable always built even when build_by_default is false mesonbuild/meson#2518)

@lhmouse lhmouse self-requested a review September 9, 2024 16:34
lhmouse
lhmouse requested changes Sep 10, 2024
View reviewed changes
meson.options
@@ -15,3 +15,7 @@
option('enable-debug-checks',
type: 'boolean', value: false,
description: 'enable run-time assertions')

option('build-test',
type: 'boolean', value: false,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option should be named enable-tests, and should have a default value of true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhmouse lhmouse lhmouse requested changes

Assignees
No one assigned
Labels
category:problem-minor priority:normal status:pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@star-hengxing @lhmouse