Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove etcetera dependency #132

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Remove etcetera dependency #132

merged 1 commit into from
Nov 2, 2023

Conversation

lunacookies
Copy link
Collaborator

Using a crates.io dependency for code this trivial is pointless.

@lunacookies
Copy link
Collaborator Author

Hmm, I’m not sure about this. Should we error if the home directory can’t be determined? I can imagine someone with a weird environment being more confused about their config being silently ignored, rather than getting an actual error.

Copy link
Owner

@lhvy lhvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😳

@lhvy lhvy merged commit b91e974 into master Nov 2, 2023
8 checks passed
@lhvy lhvy deleted the no-etcetera branch November 2, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants