-
Notifications
You must be signed in to change notification settings - Fork 165
feat(schema-meta): Add context-aware schema metadata generation #1099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ing metadata for context-aware suggestions - Updated `processGenerateSchemaMeta` to fetch and validate current schema metadata from GitHub. - Modified `generateSchemaMeta` to accept current schema metadata, allowing for incremental improvements in suggestions. - Improved documentation to reflect the context-aware nature of the schema metadata generation process.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Updates to Preview Branch (add-current-override-file-toprompt) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -33,6 +39,8 @@ Your response must strictly follow this JSON Schema: | |||
3. New relationships should capture implicit connections in the data model | |||
4. Added columns should support better data modeling without breaking existing functionality | |||
5. All suggestions must maintain backwards compatibility | |||
6. Build upon the current schema metadata when appropriate, don't duplicate existing metadata | |||
7. Focus on incremental improvements rather than wholesale replacement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍
@@ -33,6 +39,8 @@ Your response must strictly follow this JSON Schema: | |||
3. New relationships should capture implicit connections in the data model | |||
4. Added columns should support better data modeling without breaking existing functionality | |||
5. All suggestions must maintain backwards compatibility | |||
6. Build upon the current schema metadata when appropriate, don't duplicate existing metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't duplicate existing metadata
I see 👀
some conflicts exist. please check 🙏 @MH4GF |
frontend/packages/prompt-test result: ✅️ Promptfoo test succeeded
|
CI Feedback 🧐(Feedback updated until commit 36ae86d)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
ecad120
to
36ae86d
Compare
Related Issue
N/A
What does this PR do?
Enhances the schema metadata generation pipeline to use existing metadata as context for generating new suggestions. The AI prompt now receives the current schema metadata file content, allowing it to build upon existing metadata rather than generating from scratch. This enables more informed and incremental improvements to schema metadata.
What should reviewers focus on?
How has this been tested?
Tested with existing PR reviews to verify that generated schema metadata builds upon existing suggestions.
What was done
🤖 Generated by PR Agent at 7bcb668
safeParse
function.Detailed Changes
processGenerateSchemaMeta.ts
Fetch and validate current schema metadata for prompts
frontend/packages/jobs/src/functions/processGenerateSchemaMeta.ts
safeParse
for type-safe validation of schema metadata.processGenerateSchemaMeta
to pass current metadata to theprompt.
generateSchemaMeta.ts
Enhance schema metadata prompt with context-awareness
frontend/packages/jobs/src/prompts/generateSchemaMeta/generateSchemaMeta.ts
progress.md
Update progress documentation for schema metadata enhancements
memory-bank/progress.md
systemPatterns.md
Document system pattern for context-aware schema metadata
memory-bank/systemPatterns.md
techContext.md
Update tech context for schema metadata improvements
memory-bank/techContext.md
Additional Notes
This change improves the quality of schema metadata suggestions by providing more context to the AI model.