Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📈 Enable GTM tracking in all environments #581

Merged
merged 1 commit into from
Jan 27, 2025
Merged

📈 Enable GTM tracking in all environments #581

merged 1 commit into from
Jan 27, 2025

Conversation

junkisai
Copy link
Member

@junkisai junkisai commented Jan 27, 2025 •
edited
Loading

Summary

Passing appEnv to Google Tag Manager allows for reliable behavioral log tracking across all environments.

Related Issue

N/A

Changes

N/A

Testing

N/A

Other Information

N/A

@junkisai junkisai self-assigned this Jan 27, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2025

⚠️ No Changeset found

Latest commit: e9ca9cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@junkisai junkisai marked this pull request as ready for review January 27, 2025 08:46
@junkisai junkisai requested a review from a team as a code owner January 27, 2025 08:46
@junkisai junkisai requested review from hoshinotsuyoshi, FunamaYukina, MH4GF and sasamuku and removed request for a team January 27, 2025 08:46
sasamuku
sasamuku approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@sasamuku sasamuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@junkisai junkisai added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 00092b3 Jan 27, 2025
13 checks passed
@junkisai junkisai deleted the feat/tracking-all-enviroment branch January 27, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasamuku sasamuku sasamuku approved these changes

@hoshinotsuyoshi hoshinotsuyoshi Awaiting requested review from hoshinotsuyoshi hoshinotsuyoshi is a code owner automatically assigned from liam-hq/liam-dev

@FunamaYukina FunamaYukina Awaiting requested review from FunamaYukina FunamaYukina is a code owner automatically assigned from liam-hq/liam-dev

@MH4GF MH4GF Awaiting requested review from MH4GF MH4GF is a code owner automatically assigned from liam-hq/liam-dev

Assignees

@junkisai junkisai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junkisai @sasamuku