Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄Fixed icon size #584

Merged
merged 2 commits into from
Jan 29, 2025
Merged

💄Fixed icon size #584

merged 2 commits into from
Jan 29, 2025

Conversation

ya2s
Copy link
Contributor

@ya2s ya2s commented Jan 27, 2025

Summary

Since the size of the icon may be smaller than 16px, specify the minimum size.

before
CleanShot 2025-01-28 at 23 44 29@2x

after
CleanShot 2025-01-28 at 23 44 54@2x

Related Issue

Changes

Testing

Other Information

@ya2s ya2s requested a review from a team as a code owner January 27, 2025 14:36
@ya2s ya2s requested review from hoshinotsuyoshi, FunamaYukina, junkisai, MH4GF and sasamuku and removed request for a team January 27, 2025 14:36
Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: 18db4ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@liam-hq/erd-core Patch
@liam-hq/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MH4GF
Copy link
Member

MH4GF commented Jan 28, 2025

@ya2s Thanks for your PR! It looks good, but please explain the change in the UI. Screenshots before and after the change would be helpful.

@MH4GF
Copy link
Member

MH4GF commented Jan 28, 2025

@ya2s And, Please add a changeset file for erd-core and cli .
#584 (comment)

Copy link
Member

@MH4GF MH4GF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@MH4GF MH4GF added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 6c6ee19 Jan 29, 2025
13 checks passed
@MH4GF MH4GF deleted the feat/small-icon branch January 29, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants