Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint #533

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Update eslint #533

merged 2 commits into from
Jun 11, 2024

Conversation

Pactionly
Copy link
Contributor

This PR updates eslint to >= 9.0.0 , and makes the corresponding changes to the eslint configuration to account for this. Additionally updates linting for some mocha test files to match with new expected style.

This PR also updates on line of 'package.json' for Husky that was causing issues while running locally. We should review that at some point to make sure Husky is still working, or switch to pre-commit

Copy link

Terraform Plan Changes

Terraform Plan: 0 to be created, 0 to be deleted, 1 to be updated, 0 to be replaced, 5 unchanged.

Resources to update

! azurerm_linux_web_app.gratibot_app_service

Copy link
Contributor

@zjorge96 zjorge96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eslint is still working with the changes in place. All commands and tests are working. 🙌

@Pactionly Pactionly merged commit 79e31a7 into main Jun 11, 2024
14 checks passed
@Pactionly Pactionly deleted the update-eslint branch June 11, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants