Skip to content

Commit

Permalink
Fix GitHub Actions workflows failing due to using glibc 2.17
Browse files Browse the repository at this point in the history
PR #23 (#0774bd6) added a container setup to build with glibc 2.17. Unfortunately, GitHub recently started forcing actions to run on Node 20 instead of Node 16 (https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/). Node 20 does not work with glibc 2.17 and using it results in the build failing.

This commit temporarily fixes build issues by using the environment variable mentioned on the aforementioned page. We will need a longer term solution soon however, as once download-artifact@v3 and upload-artifact@v3 are deprecated, we will be forced to use v4 versions which require Node 20.
  • Loading branch information
SonicGDX committed Oct 16, 2024
1 parent 0774bd6 commit 0c8b44c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/pushaction.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ name: Compile and deploy snapshot artifacts
on: [push, pull_request] # Don't worry, the actual deployment is guarded with an "if" and only done on push to master
env:
GRADLE_USER_HOME: .gradle
# Needed in order to use Node 16. Node 20 does not work with glibc 2.17
# See https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true

jobs:
macos:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/releaseaction.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:

env:
GRADLE_USER_HOME: .gradle
# Needed in order to use Node 16. Node 20 does not work with glibc 2.17
# See https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true

jobs:
macos:
Expand Down

0 comments on commit 0c8b44c

Please sign in to comment.