-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wheel support for musllinux #1266
Conversation
4b67f81
to
aeb9012
Compare
See: https://github.com/jimisola/pygit2/actions/runs/7480533793/job/20360154960#step:6:10758 I've turned all combinations back on again and the workflow is running now. It seems to take around 2h10 for it to complete so, I'll have to check it tomorrow: https://github.com/jimisola/pygit2/actions/runs/7480815724/job/20361072244
See: https://github.com/jimisola/pygit2/actions/runs/7480815722/job/20361073118#step:4:1804
a. remove musl branchfrom wheels workflow: push:
branches:
- master
- musl b. squash commits upon merge |
Update:
|
I've re-run an old job and it fails as well, https://github.com/libgit2/pygit2/actions/runs/7480816047 Apparently there's a change in Pypy 7.3.14 that is the source of this failure. Just remove the commented out lines, remove the musl branch from wheels workflow, rebase and squash. |
d371d33
to
ff0b1c4
Compare
Fixed. Ready for merge. For planning purposes, when do you think that there will be a new release with musllinux wheel support? Thanks for a great project. |
@jimisola Soon after CI is green again, but don't know when the Pypy error will be fixed. |
Ok. Thanks. Is there an issue a pypy that one can follow? |
Apparently this has been fixed in latest version, PyPy v7.3.15 But the wheels now take a lot more time to build.
What do you actually need? |
Great. I think it's enough for us with what you've listed, but just let me double-check and get back to you. And yes, I noticed that wheels take a lot longer. Is that an actual problem - built-time and/or CI/CD minutes? |
@jdavid Let's go with your suggestion: x86_64 and Python, 3.12 and 3.11 |
@jdavid Did you see this? Should improve execution time a bit. https://github.blog/2024-01-17-github-hosted-runners-double-the-power-for-open-source/ |
Release done. Finally I only dropped the wheels for aarch64, that's what takes most time. |
Great. Thanks for accepting the PR and the continued work with it. |
Resolves: #1216