typecheck-part-1 #1350
typecheck-part-1 #1350
Conversation
| lint.select = [ | ||
| "E", | ||
| "W", | ||
| "F", | ||
| "I", | ||
| "B", | ||
| "C4", | ||
| "ARG", | ||
| "SIM", | ||
| "PTH", | ||
| "PL", | ||
| "TID", | ||
| ] | ||
| lint.ignore = [ |
There was a problem hiding this comment.
How come you're not using this instead, for select and ignore?
[tool.ruff.lint]As seen (and suggested one might say) in ruff's docs.
| @@ -25,15 +25,53 @@ environment = {LIBGIT2_VERSION="1.9.0", LIBSSH2_VERSION="1.11.1", OPENSSL_VERSIO | |||
| repair-wheel-command = "DYLD_LIBRARY_PATH=/Users/runner/work/pygit2/pygit2/ci/lib delocate-wheel --require-archs {delocate_archs} -w {dest_dir} {wheel}" | |||
|
|
|||
| [tool.ruff] | |||
| target-version = "py310" # oldest supported Python version | |||
| fix = true | |||
There was a problem hiding this comment.
Shouldn't fixes be opt-in, instead of opt-out? 🤔 Would you mind elaborating on your reasoning?
| "W291", # Trailing whitespace | ||
| "E501", # Line too long | ||
| "W293", # Blank line contains whitespace | ||
| "PLR0912", # Too many branches | ||
| "PLR2004", # Magic values | ||
| "PLR0915", # Too many statements | ||
| "PLW0603", # Global statement | ||
| "PLR0913", # Too many arguments | ||
| "B010", # setattr | ||
| "F401", # unused imports | ||
| "ARG002", # unused arguments | ||
| "SIM105", # try-except-pass |
There was a problem hiding this comment.
Are you ignoring them because there are many fixes to be made?
If so, the suggested approach is not to ignore them at the configuration level, but run ruff with --add-noqa, as seen here.
When enabling a new rule on an existing codebase, you may want to ignore all existing violations of that rule and instead focus on enforcing it going forward.
|
|
||
| [tool.ruff.format] | ||
| quote-style = "single" | ||
|
|
||
| [tool.pyright] |
There was a problem hiding this comment.
You are adding a pyright configuration but pyright is not in the repo in any capacity.
Split from #1332